clamping the return value of uniform.cdf() to [0..1] (#7538)

andreh7 · ezyang · commit 61afbbbd185a · 2018-05-14T15:36:00.000-04:00
* fix for #7532: clamping the return value of uniform.cdf() to the range [0,1] * removed whitespace around equals to pass flake8 tests * added a test for uniform.cdf() with arguments outside support
diff --git a/test/test_distributions.py b/test/test_distributions.py
@@ -1126,6 +1126,10 @@ def test_uniform(self):
         self.assertEqual(uniform.log_prob(above_high).item(), -float('inf'), allow_inf=True)
         self.assertEqual(uniform.log_prob(below_low).item(), -float('inf'), allow_inf=True)
 
+        # check cdf computation when value outside range
+        self.assertEqual(uniform.cdf(below_low).item(), 0)
+        self.assertEqual(uniform.cdf(above_high).item(), 1)
+
         set_rng_seed(1)
         self._gradcheck_log_prob(Uniform, (low, high))
         self._gradcheck_log_prob(Uniform, (low, 1.0))
diff --git a/torch/distributions/uniform.py b/torch/distributions/uniform.py
@@ -71,7 +71,7 @@ def cdf(self, value):
         if self._validate_args:
             self._validate_sample(value)
         result = (value - self.low) / (self.high - self.low)
-        return result
+        return result.clamp(min=0, max=1)
 
     def icdf(self, value):
         if self._validate_args:
