Better print of nn Containers (#8939)

karandwivedi42 · facebook-github-bot · commit 37e526e1a8cf · 2018-06-29T08:24:09.000-07:00
Summary: Fix #8900 Waiting on #8463 1. Remove extra Line 2. ... Closes #8939 Reviewed By: soumith Differential Revision: D8687730 Pulled By: ezyang fbshipit-source-id: 81c57a03683875704d537cb4585b11838f70df56
diff --git a/torch/nn/modules/container.py b/torch/nn/modules/container.py
@@ -268,11 +268,12 @@ def extend(self, parameters):
         return self
 
     def extra_repr(self):
-        tmpstr = ''
+        child_lines = []
         for k, p in self._parameters.items():
             size_str = 'x'.join(str(size) for size in p.size())
             device_str = '' if not p.is_cuda else ' (GPU {})'.format(p.get_device())
             parastr = 'Parameter containing: [{} of size {}{}]'.format(
                 torch.typename(p.data), size_str, device_str)
-            tmpstr = tmpstr + '  (' + k + '): ' + parastr + '\n'
+            child_lines.append('  (' + k + '): ' + parastr)
+        tmpstr = '\n'.join(child_lines)
         return tmpstr
