Add cpp stack traces to our own reruns (#119408)

albanD · pytorchmergebot · commit 30625ae58228 · 2024-02-26T22:21:14.000Z
Note that I'm not sure why we both have pytest rerun the failing test twice via https://github.com/pytorch/pytorch/blob/81abc2b2494ab7d48394b63d528eb5dddfa9d3d5/test/run_test.py#L966 before our own logic retries it as well? The failing test is only here to make sure it works as expected in the CI env. Will remove before landing. Pull Request resolved: #119408 Approved by: https://github.com/huydhn
diff --git a/test/run_test.py b/test/run_test.py
@@ -26,6 +26,7 @@
     FILE_SCHEMA,
     get_report_path,
     IS_CI,
+    IS_MACOS,
     parser as common_parser,
     retry_shell,
     set_cwd,
@@ -617,6 +618,16 @@ def print_to_file(s):
         else:
             sc_command = f"--sc={stepcurrent_key}"
         print_to_file("Retrying...")
+        # Print full c++ stack traces during retries
+        # Don't do it for macos inductor tests as it makes them
+        # segfault for some reason
+        if not (
+            IS_MACOS
+            and len(command) >= 2
+            and command[2].startswith(INDUCTOR_TEST_PREFIX)
+        ):
+            env = env or {}
+            env["TORCH_SHOW_CPP_STACKTRACES"] = "1"
         print_items = []  # do not continue printing them, massive waste of space
 
     consistent_failures = [x[1:-1] for x in num_failures.keys() if num_failures[x] >= 3]
