Don't re run CSE on every block

eellison · eellison · commit 2ea74b99352d · 2020-07-17T10:42:10.000-07:00
ghstack-source-id: bd25b5c Pull Request resolved: #41479
diff --git a/torch/csrc/jit/passes/create_autodiff_subgraphs.cpp b/torch/csrc/jit/passes/create_autodiff_subgraphs.cpp
@@ -88,9 +88,6 @@ class SubgraphSlicer {
       }
       curNode = prevNode;
     }
-    // Run CSE one more time to eliminate duplicates that may have occurred
-    // while re-inlining subgraphs.
-    EliminateCommonSubexpression(graph_);
   }
 
  private:
@@ -231,6 +228,9 @@ std::vector<Node*> CreateAutodiffSubgraphs(
     size_t threshold) {
   std::vector<Node*> diff_nodes;
   SubgraphSlicer(graph->block(), graph, threshold).run(diff_nodes);
+  // Run CSE to eliminate duplicates that may have occurred
+  // while inlining subgraphs.
+  EliminateCommonSubexpression(graph);
   return diff_nodes;
 }
 } // namespace jit

Original file line number	Diff line number	Diff line change
`@@ -88,9 +88,6 @@ class SubgraphSlicer {`
`88`	`88`	`}`
`89`	`89`	`curNode = prevNode;`
`90`	`90`	`}`
`91`		`- // Run CSE one more time to eliminate duplicates that may have occurred`
`92`		`- // while re-inlining subgraphs.`
`93`		`- EliminateCommonSubexpression(graph_);`
`94`	`91`	`}`
`95`	`92`
`96`	`93`	`private:`
`@@ -231,6 +228,9 @@ std::vector<Node*> CreateAutodiffSubgraphs(`
`231`	`228`	`size_t threshold) {`
`232`	`229`	`std::vector<Node*> diff_nodes;`
`233`	`230`	`SubgraphSlicer(graph->block(), graph, threshold).run(diff_nodes);`
	`231`	`+ // Run CSE to eliminate duplicates that may have occurred`
	`232`	`+ // while inlining subgraphs.`
	`233`	`+ EliminateCommonSubexpression(graph);`
`234`	`234`	`return diff_nodes;`
`235`	`235`	`}`
`236`	`236`	`} // namespace jit`