Skip to content

Commit 29ffa20

Browse files
eqypytorchmergebot
authored andcommitted
[CUDA] Bump tolerances for test_grad_pca_lowrank (#129902)
The revert of #127199 seems to surface an additional failure on A100---small tolerance bump to account for this. I did find what appears to be a race condition in the one of the kernels used in this workload but I'm not sure it's related here... CC @nWEIdia Pull Request resolved: #129902 Approved by: https://github.com/ezyang
1 parent b5fdbc1 commit 29ffa20

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

torch/testing/_internal/common_methods_invocations.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17822,6 +17822,8 @@ def sample_inputs_alias_copy(op_info, device, dtype, requires_grad, **kwargs):
1782217822
DecorateInfo(toleranceOverride({torch.float32: tol(atol=1e-03, rtol=1e-03),
1782317823
torch.complex64: tol(atol=1e-02, rtol=1e-02)}),
1782417824
'TestCommon', 'test_noncontiguous_samples'),
17825+
DecorateInfo(toleranceOverride({torch.float32: tol(atol=1e-05, rtol=5e-05)}),
17826+
'TestOperators', 'test_grad'),
1782517827
# FIXME This should be the following, but the toleranceOverride does not seem to do anything!
1782617828
# DecorateInfo(toleranceOverride({torch.complex128: tol(atol=1e-04, rtol=1e-04)}),
1782717829
# 'TestFwdGradients', 'test_fn_fwgrad_bwgrad'),

0 commit comments

Comments
 (0)