Update on "extend torch.jit._overload to module methods"

root · root · commit 0550cfb383dc · 2019-08-20T11:47:18.000-07:00
Follow up to #23886, add the same overload api specified in PEP 484 to module methods to reduce the friction of adding method overloads that was brought up in #23266. The usage is: ``` @torch.jit.overload def add(self, y: int) -> int: ... @torch.jit.overload def add(self, y: float) -> float: ... def add(): ... ``` Differential Revision: [D16921304](https://our.internmc.facebook.com/intern/diff/D16921304)
diff --git a/torch/jit/_recursive.py b/torch/jit/_recursive.py
@@ -156,7 +156,6 @@ def recursive_script(mod, exclude_methods=()):
     # we shouldn't directly compile overloaded methods, just its overloads
     def ignore_overloaded(method_name):
         return method_name not in overload_name_mappings
->>>>>>> extend torch.jit._overload to modules
 
     def make_stub(method):
         func = get_function_from_type(type(mod), method)
