Skip to content

Honor configured A16 weight ranges - #22769

Open
Ivan-Dimitrov wants to merge 1 commit into
pytorch:mainfrom
Ivan-Dimitrov:export-D119779205
Open

Honor configured A16 weight ranges#22769
Ivan-Dimitrov wants to merge 1 commit into
pytorch:mainfrom
Ivan-Dimitrov:export-D119779205

Conversation

@Ivan-Dimitrov

@Ivan-Dimitrov Ivan-Dimitrov commented Sep 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary: Forward the existing weight_qmin and weight_qmax arguments into the Arm symmetric A16W8 quantization configuration in both the fbcode and xplat mirrors. Callers that omit the arguments retain the existing [-127, 127] weight range; restricted-range recipes receive the requested qspec.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

@Ivan-Dimitrov @facebook-github-bot
Honor configured A16 weight ranges
edba2ee 
Summary: Forward the existing weight_qmin and weight_qmax arguments into the Arm symmetric A16W8 quantization configuration in both the fbcode and xplat mirrors. Callers that omit the arguments retain the existing [-127, 127] weight range; restricted-range recipes receive the requested qspec.

Differential Revision: D119779205
@pytorch-bot

pytorch-bot Bot commented Sep 12, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22769

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 6 Unrelated Failures

As of commit edba2ee with merge base 1abaa87 (image):

NEW FAILURES - The following jobs have failed:

  • Cadence Build & Test / cpu-test / Resolve CI docker image / resolve (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / hifi-build / hifi4 (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • pull / unittest / windows / windows-job (gh)
    examples/models/test/test_export.py::ExportTest::test_efficient_sam_export_to_executorch

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2026
@meta-codesync

meta-codesync Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

@Ivan-Dimitrov has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119779205.

@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Sep 12, 2026
@github-actions

github-actions Bot commented Sep 12, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: arm Issues related to arm backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Ivan-Dimitrov