-
Notifications
You must be signed in to change notification settings - Fork 376
fix: Windows CI Experimentation #2702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1e418b6 to
b2b5717
Compare
|
My previous commit can only build with TRT 8. To build with TRT 9 there are some necessary changes in https://github.com/HolyWu/TensorRT/commit/f644baa4f073afcb7e27ee655d62771607c4a7c2. Besides, if you prefer building from archives rather than using local sources, it's also doable in https://github.com/HolyWu/TensorRT/commit/b54a3bf9962b91a22f445596a53e24e7be740bfe. |
0045465 to
ae453fc
Compare
eba6b44 to
0e6a5cd
Compare
|
I don't think you can install/upgrade the display driver via conda because the nvidia packages in conda seems to not include the display driver. Only the official CUDA Toolkit installer includes the display driver component. I'm not sure if you can successfully execute the network installer in silent mode to only install the display driver on the windows runner, because it may require admin privilege or rebooting. On the other hand, maybe poke the pytorch guys to upgrade the driver on their windows runner is a better solution. |
|
Thanks for this feedback - I am looking into getting the driver version for Windows updated here. |
|
The default shell on Windows runner is |
|
I have managed to fix the CI errors in my fork, including successful C++ building. Because I cannot use PyTorch-hosted runner in my fork, I have to run on GitHub-hosted runner. But GitHub-hosted runner doesn't have GPU support, so I cannot run pytest. Some things you need to do besides reverting back to use pytorch's repo in https://github.com/HolyWu/TensorRT/commit/fa7ecc973d58c960fd4d0f8ecb05467f772c583a:
|
|
Don't forget to set |
|
Hmm...maybe you need to set https://github.com/gs-olive/test-infra/blob/0c5cc5b410cfaa6953a15fdd564c2399a95b185e/.github/workflows/build_wheels_windows.yml#L80 back to |
|
That worked - thank you! Now looking into why this error is appearing during install: It seems that even though the builds are named |
dc57848 to
1c02aa3
Compare
This reverts commit 6d664c0.
7b744b7 to
9b5be69
Compare
Experimentation of windows CI job with upgraded C++ build and package runtime changes