Skip to content

Conversation

@gs-olive
Copy link
Contributor

Experimentation of windows CI job with upgraded C++ build and package runtime changes

@gs-olive gs-olive added the WIP Work is in progress, pull request should not be merged yet label Mar 21, 2024
@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: converters Issues re: Specific op converters component: build system Issues re: Build system component: api [Python] Issues re: Python API component: api [C++] Issues re: C++ API component: runtime labels Mar 21, 2024
@github-actions github-actions bot requested a review from peri044 March 21, 2024 23:49
@gs-olive gs-olive removed the request for review from peri044 March 22, 2024 00:12
@gs-olive gs-olive force-pushed the windows_CI_experimentation_2 branch 2 times, most recently from 1e418b6 to b2b5717 Compare March 22, 2024 00:54
@HolyWu
Copy link
Contributor

HolyWu commented Mar 22, 2024

My previous commit can only build with TRT 8. To build with TRT 9 there are some necessary changes in https://github.com/HolyWu/TensorRT/commit/f644baa4f073afcb7e27ee655d62771607c4a7c2. Besides, if you prefer building from archives rather than using local sources, it's also doable in https://github.com/HolyWu/TensorRT/commit/b54a3bf9962b91a22f445596a53e24e7be740bfe.

@github-actions github-actions bot added component: tests Issues re: Tests component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Mar 22, 2024
@gs-olive gs-olive force-pushed the windows_CI_experimentation_2 branch from eba6b44 to 0e6a5cd Compare March 23, 2024 04:50
@github-actions github-actions bot removed component: tests Issues re: Tests component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Mar 23, 2024
@HolyWu
Copy link
Contributor

HolyWu commented Mar 26, 2024

I don't think you can install/upgrade the display driver via conda because the nvidia packages in conda seems to not include the display driver. Only the official CUDA Toolkit installer includes the display driver component. I'm not sure if you can successfully execute the network installer in silent mode to only install the display driver on the windows runner, because it may require admin privilege or rebooting.

On the other hand, maybe poke the pytorch guys to upgrade the driver on their windows runner is a better solution.

@gs-olive
Copy link
Contributor Author

Thanks for this feedback - I am looking into getting the driver version for Windows updated here.

@github-actions github-actions bot added the component: tests Issues re: Tests label Mar 27, 2024
@HolyWu
Copy link
Contributor

HolyWu commented Apr 5, 2024

The default shell on Windows runner is powershell. You need to change the shell in Pack script to bash like https://github.com/gs-olive/TensorRT/blob/2b25c988970a8e4282cf5f5e58a2a116e74436b0/.github/workflows/windows-test.yml#L137 since most commands in the workflow are not supported by powershell.

@HolyWu
Copy link
Contributor

HolyWu commented Apr 8, 2024

I have managed to fix the CI errors in my fork, including successful C++ building. Because I cannot use PyTorch-hosted runner in my fork, I have to run on GitHub-hosted runner. But GitHub-hosted runner doesn't have GPU support, so I cannot run pytest.

Some things you need to do besides reverting back to use pytorch's repo in https://github.com/HolyWu/TensorRT/commit/fa7ecc973d58c960fd4d0f8ecb05467f772c583a:

@HolyWu
Copy link
Contributor

HolyWu commented Apr 10, 2024

Don't forget to set setup-miniconda to false in windows-test.yml when using pytorch's Windows runner.

@HolyWu
Copy link
Contributor

HolyWu commented Apr 10, 2024

Hmm...maybe you need to set https://github.com/gs-olive/test-infra/blob/0c5cc5b410cfaa6953a15fdd564c2399a95b185e/.github/workflows/build_wheels_windows.yml#L80 back to windows-2019? It's the culprit of the Called workflows cannot be queued onto self-hosted runners across organizations/enterprises. error.

@gs-olive
Copy link
Contributor Author

gs-olive commented Apr 10, 2024

That worked - thank you! Now looking into why this error is appearing during install:

ERROR: torch_tensorrt-2.3.0.dev0+6031b50-cp39-cp39-win_amd64.whl is not a supported wheel on this platform.

It seems that even though the builds are named py38, they are building for py39, which might be contributing

@gs-olive gs-olive force-pushed the windows_CI_experimentation_2 branch from dc57848 to 1c02aa3 Compare April 10, 2024 23:04
@gs-olive gs-olive force-pushed the windows_CI_experimentation_2 branch from 7b744b7 to 9b5be69 Compare April 19, 2024 00:01
@gs-olive gs-olive changed the base branch from min_cpp_build to main April 19, 2024 00:01
@narendasan narendasan closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [C++] Issues re: C++ API component: api [Python] Issues re: Python API component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: lowering Issues re: The lowering / preprocessing passes component: runtime WIP Work is in progress, pull request should not be merged yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants