Skip to content

fix: Repair argument passing in both Dynamo paths #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
peri044 merged 1 commit into from
Jun 28, 2023
Merged

fix: Repair argument passing in both Dynamo paths #1997

peri044 merged 1 commit into from
Jun 28, 2023

Conversation

@gs-olive
Copy link
Contributor

@gs-olive gs-olive commented Jun 7, 2023 •
edited
Loading

Description

  • Pass-through new TRT args in export
  • Fix bug in fx_ts_compat where explicit_batch_dimension did not exist in input args
  • Pass-through build failures arg in compile

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive added the component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths label Jun 7, 2023
@gs-olive gs-olive requested a review from narendasan June 7, 2023 22:48
@gs-olive gs-olive self-assigned this Jun 7, 2023
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label Jun 7, 2023
@gs-olive gs-olive mentioned this pull request Jun 7, 2023
Merged
github-actions[bot]
github-actions bot approved these changes Jun 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive mentioned this pull request Jun 7, 2023
Closed
narendasan
narendasan reviewed Jun 7, 2023
View reviewed changes
@gs-olive gs-olive force-pushed the dynamo_arg_issues branch from acbc3ff to b97e5c4 Compare June 8, 2023 00:13
github-actions[bot]
github-actions bot approved these changes Jun 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive requested a review from narendasan June 8, 2023 00:14
github-actions[bot]
github-actions bot approved these changes Jun 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive requested a review from peri044 June 8, 2023 16:35
github-actions[bot]
github-actions bot approved these changes Jun 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

peri044
peri044 reviewed Jun 13, 2023
View reviewed changes
py/torch_tensorrt/dynamo/fx_ts_compat/lower.py Outdated
save_timing_cache=False,
cuda_graph_batch_size=-1,
is_aten=False,
explicit_batch_dimension=True,
Copy link
Collaborator

@peri044 peri044 Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove this flag altogether ? . It is deprecated in TRT and not present in Torchscript.

Copy link
Contributor Author

@gs-olive gs-olive Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it should be removed from all of the FX code or only the Dynamo FX code?

Copy link
Contributor Author

@gs-olive gs-olive Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed all references to explicit_batch_dimension (deprecated to not use) and explicit_precision (has no effect), within the Dynamo code.

@gs-olive gs-olive requested a review from peri044 June 20, 2023 20:06
github-actions[bot]
github-actions bot approved these changes Jun 20, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 20, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@gs-olive
fix: Repair argument passing in both Dynamo paths
f8bab8f 
- Pass-through new TRT args in export
- Pass-through build failures arg in compile
- Remove deprecated options including `explicit_batch_dimension` and
`explicit_precision` from Dynamo utilities and update references to
those options in settings
@gs-olive gs-olive force-pushed the dynamo_arg_issues branch from b97e5c4 to f8bab8f Compare June 22, 2023 20:32
github-actions[bot]
github-actions bot approved these changes Jun 22, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 22, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

gs-olive
gs-olive commented Jun 28, 2023
View reviewed changes
peri044
peri044 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 66af8a4 into main Jun 28, 2023
@gs-olive gs-olive deleted the dynamo_arg_issues branch June 28, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peri044 peri044 peri044 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@gs-olive gs-olive

Labels

cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gs-olive @narendasan @peri044 @facebook-github-bot