Reorg for converters in (FX Converter Refactor [1/N]) #1867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: api [Python]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
narendasan
requested review from
frank-wei and
wushirong
and removed request for
yinghai
narendasan
force-pushed
the
converter_reorg_proto
branch
from
737b667 to
dfd98a5
Compare
narendasan
changed the title
narendasan
changed the title
narendasan
force-pushed
the
converter_reorg_proto
branch
from
dfd98a5 to
c438fe2
Compare
narendasan
force-pushed
the
converter_reorg_proto
branch
from
c438fe2 to
9cec91e
Compare
narendasan
force-pushed
the
converter_reorg_proto
branch
from
9cec91e to
9864d96
Compare
narendasan
force-pushed
the
converter_reorg_proto
branch
from
9864d96 to
8822b66
Compare
narendasan
force-pushed
the
converter_reorg_proto
branch
from
8822b66 to
1696cd2
Compare
7 tasks
Collaborator
Author
|
It is not possible to further reduce the size of the PR without the build breaking (i.e. breaking main on merge) since by moving the convert_activation function a number of references must be updated. This constitute 90% of changes in this PR. There are 3 major themes in this PR
You can move the relu change out but that is a trivial change and will not reduce the size of the PR significantly. |
…ementation, example changes with ReLU Signed-off-by: Naren Dasan <naren@narendasan.com>
gs-olive
force-pushed
the
converter_reorg_proto
branch
from
1696cd2 to
12f545c
Compare
Collaborator
Author
|
@wushirong Can you review this PR. This is gating release of 1.4 |
narendasan
added a commit
that referenced
this pull request
Jun 2, 2023
Signed-off-by: Naren Dasan <naren@narendasan.com>
narendasan
added a commit
that referenced
this pull request
Jun 3, 2023
Signed-off-by: Naren Dasan <naren@narendasan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposes reorganization of the converters to separate IR from implementation.
Introduces
SourceIRenum to inform downstream tasks of any necessary special cases.Note: This PR cannot be merged without child PRs updating uses ofcommon_activationandadd_activationto use the new method.Type of change
Please delete options that are not relevant and/or add your own.
Checklist: