Skip to content

[feat] Add dynamic conversion path to aten::mul evaluator #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
peri044 merged 1 commit into from
Apr 7, 2023
Merged

[feat] Add dynamic conversion path to aten::mul evaluator #1710

peri044 merged 1 commit into from
Apr 7, 2023

Conversation

@mfeliz-cruise
Copy link
Contributor

@mfeliz-cruise mfeliz-cruise commented Mar 2, 2023

Description

Adds dynamic conversion path to support aten::mul on the output of dynamic aten::size.
Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: evaluators Issues re: Specific op evaluators component: tests Issues re: Tests labels Mar 2, 2023
@github-actions github-actions bot requested a review from peri044 March 2, 2023 20:50
@peri044
Copy link
Collaborator

peri044 commented Apr 5, 2023

@mfeliz-cruise I fixed the failing dynamic_size test. Can you rebase with aten_size_fix branch to trigger your tests based off the new fix ?

@mfeliz-cruise mfeliz-cruise force-pushed the michael.feliz/dynamic_aten_mul branch from 9cfb203 to 02d502c Compare April 7, 2023 01:20
@github-actions github-actions bot added the component: converters Issues re: Specific op converters label Apr 7, 2023
@mfeliz-cruise mfeliz-cruise changed the base branch from aten_size_fix to main April 7, 2023 01:21
peri044
peri044 approved these changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 34a3328 into pytorch:main Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peri044 peri044 peri044 approved these changes

Assignees

No one assigned

Labels

cla signed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: evaluators Issues re: Specific op evaluators component: tests Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfeliz-cruise @peri044 @facebook-github-bot