fix: Send correct key for exc errno

untitaker · untitaker · commit 2f5487235848 · 2019-04-10T17:53:31.000+02:00
diff --git a/sentry_sdk/utils.py b/sentry_sdk/utils.py
@@ -495,8 +495,9 @@ def single_exception_from_error_tuple(
 
     if errno is not None:
         mechanism = mechanism or {}
-        mechanism_meta = mechanism.setdefault("meta", {})
-        mechanism_meta.setdefault("errno", {"code": errno})
+        mechanism.setdefault("meta", {}).setdefault("errno", {}).setdefault(
+            "number", errno
+        )
 
     if client_options is None:
         with_locals = True
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -85,6 +85,7 @@ def inner(event):
             ).decode("utf-8")
         )
         _no_errors_in_semaphore_response(output)
+        output.pop("_meta", None)
 
     return inner
 
diff --git a/tests/test_client.py b/tests/test_client.py
@@ -459,3 +459,18 @@ def __repr__(self):
         event["exception"]["values"][0]["stacktrace"]["frames"][0]["vars"]["a"]
         == "<broken repr>"
     )
+
+
+def test_errno_errors(sentry_init, capture_events):
+    sentry_init()
+    events = capture_events()
+
+    class Foo(Exception):
+        errno = 69
+
+    capture_exception(Foo())
+
+    event, = events
+
+    exception, = event["exception"]["values"]
+    assert exception["mechanism"]["meta"]["errno"]["number"] == 69

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,7 @@ def inner(event):`
`85`	`85`	`).decode("utf-8")`
`86`	`86`	`)`
`87`	`87`	`_no_errors_in_semaphore_response(output)`
	`88`	`+ output.pop("_meta", None)`
`88`	`89`
`89`	`90`	`return inner`
`90`	`91`