-

cool-RR · cool-RR · commit e930f44cfc9a · 2014-09-27T01:06:44.000+03:00
diff --git a/source_py3/python_toolbox/combi/_variation_adding_mixin.py b/source_py3/python_toolbox/combi/_variation_adding_mixin.py
@@ -20,8 +20,9 @@ def get_rapplied(self, sequence):
             n_elements=self.n_elements, is_combination=self.is_combination
         )
     
-    # There's no `get_recurrented` because it wouldn't make sense :) You'd need
-    # to use `get_rapplied` and set a recurrent sequence.
+    # There's no `.get_recurrented` because we can't know which sequence you'd
+    # want. If you want a recurrent perm space you need to use `.get_rapplied`
+    # with a recurrent sequence.
     
     def get_partialled(self, n_elements):
         '''Get a partialled version of this `PermSpace`.'''
@@ -92,6 +93,7 @@ def get_degreed(self, degrees):
                             "`perm_space.unsliced.get_degreed(...)`.")
         if self.is_combination:
             raise Exception("Can't use degrees with combination spaces.")
+        degrees = sequence_tools.to_tuple(degrees, item_type=int)
         if not degrees:
             return self
         degrees_to_use = \
diff --git a/source_py3/python_toolbox/combi/_variation_removing_mixin.py b/source_py3/python_toolbox/combi/_variation_removing_mixin.py
@@ -22,10 +22,8 @@ class _VariationRemovingMixin:
         ),
         doc='''A version of this `PermSpace` without a custom range.'''
     )
-    unreccurented = caching.CachedProperty(
-        lambda self: 1 / 0, # blocktodo
-        doc='''A non-recurrent version of this `PermSpace`.'''
-    )
+    # There's no `.unrecurrented`; if you want to make a perm space
+    # non-recurrented, use `.unrapplied`.
 
     @caching.CachedProperty
     def unpartialled(self):
diff --git a/source_py3/python_toolbox/combi/perm_space.py b/source_py3/python_toolbox/combi/perm_space.py
@@ -30,6 +30,12 @@
 infinity = float('inf')
 
 
+class UnsupportedVariationCombinationException(Exception):
+    '''blocktodo use everywhere
+    let it take variations
+    make variation classes mostly for this and testing'''
+        
+
 class PermSpaceType(abc.ABCMeta):
     '''
     Metaclass for `PermSpace` and `CombSpace`.
@@ -321,7 +327,7 @@ def __init__(self, iterable_or_length, domain=None, n_elements=None,
             self._unsliced_length = self._unsliced_undegreed_length
         else:
             self.is_degreed = True
-            if self.is_combination or self.is_partial:
+            if self.is_combination or self.is_partial or self.is_recurrent:
                 raise NotImplementedError
             self.degrees = tuple(
                 degree for degree in degrees if degree in all_degrees
