-

Ram Rachum · Ram Rachum · commit 8c1a32251ec0 · 2011-07-21T16:53:25.000-04:00
diff --git a/garlicsim/garlicsim/general_misc/logic_tools.py b/garlicsim/garlicsim/general_misc/logic_tools.py
@@ -33,7 +33,10 @@ def all_equal(iterable, exhaustive=False):
 def logic_max(iterable, relation=lambda a, b: (a >= b)):
     '''
     Get a list of maximums from the iterable.
-        
+    
+    That is, get all items that are bigger-or-equal to all the items in the
+    iterable.
+    
     `relation` is allowed to be a partial order.
     '''
     sequence = list(iterable)
diff --git a/garlicsim/test_garlicsim/test_general_misc/test_logic_tools/test_logic_max.py b/garlicsim/test_garlicsim/test_general_misc/test_logic_tools/test_logic_max.py
@@ -10,6 +10,54 @@
 
 def test():
     '''Test the basic working of `logic_max`.'''
-    assert logic_max(range(4)) == 3
-    assert logic_max(set(range(5))) == 4
-    1/0
+    assert logic_max(range(4)) == [3]
+    assert logic_max(set(range(5))) == [4]
+    assert logic_max(iter(range(6))) == [5]
+    assert logic_max(tuple(range(10))) == [9]
+    
+    class FunkyString(object):
+        def __init__(self, string):
+            self.string = string
+            
+        def __ge__(self, other):
+            assert isinstance(other, FunkyString)
+            return other.string in self.string
+        
+        def __eq__(self, other):
+            assert isinstance(other, FunkyString)
+            return other.string == self.string
+        
+    assert logic_max(
+        [FunkyString('meow'),
+         FunkyString('meow frr'),
+         FunkyString('ow')]
+    ) == [FunkyString('meow frr')]
+    
+    assert logic_max(
+        [FunkyString('meow'),
+         FunkyString('meow frr'),
+         FunkyString('ow'),
+         FunkyString('Stanislav')]
+    ) == []
+    
+    assert logic_max(
+        [FunkyString('meow'),
+         FunkyString('meow frr'),
+         FunkyString('ow'),
+         FunkyString('meow frr')]
+    ) == [FunkyString('meow frr'), FunkyString('meow frr'),]
+
+    
+    class FunkyInt(object):
+        def __init__(self, number):
+            self.number = number
+        def __ge__(self, other):
+            return (10 <= self.number <= 20)
+        
+    assert logic_max(
+        [FunkyInt(7),
+         FunkyInt(13),
+         FunkyInt(3),
+         FunkyInt(18),
+         FunkyInt(24),]
+    ) == [FunkyInt(13), FunkyInt(18)]
