-

cool-RR · cool-RR · commit 438b83153ac8 · 2012-05-31T14:46:48.000+03:00
diff --git a/python_toolbox/cute_testing.py b/python_toolbox/cute_testing.py
@@ -40,8 +40,6 @@ def __init__(self, exception_type=Exception, text='',
         exception is of the exact `exception_type` specified, and not a
         subclass of it.
         '''
-        ContextManager.__init__(self)
-        
         self.exception_type = exception_type
         '''The type of exception that should be raised.'''
         
diff --git a/python_toolbox/monkeypatch_copy_reg.py b/python_toolbox/monkeypatch_copy_reg.py
@@ -8,7 +8,6 @@
 
 import copy_reg
 import types
-import __builtin__
 
 from python_toolbox import import_tools
 
diff --git a/python_toolbox/os_tools.py b/python_toolbox/os_tools.py
@@ -9,6 +9,7 @@
 
 
 def start_file(path):
+    '''Open a file by launching the program that handles its kind.'''
     assert os.path.exists(path)
     
     if sys.platform.startswith('linux'): # Linux:
diff --git a/python_toolbox/queue_tools.py b/python_toolbox/queue_tools.py
@@ -50,7 +50,7 @@ def iterate(queue, block=False, limit_to_original_size=False,
                 "`_prefetch_if_no_qsize=True` to have the entire queue "
                 "prefetched before yielding the items."
             )
-        for i in xrange(queue.qsize()):
+        for _ in xrange(queue.qsize()):
             try:
                 yield queue.get(block=block)
             except queue_module.Empty:
diff --git a/python_toolbox/sequence_tools.py b/python_toolbox/sequence_tools.py
@@ -7,10 +7,8 @@
 import itertools
 
 from python_toolbox.nifty_collections import Counter
-from python_toolbox import caching
 from python_toolbox import math_tools
 from python_toolbox.infinity import infinity
-from python_toolbox.third_party import abc
 from python_toolbox.third_party import abcs_collection
 
         
diff --git a/python_toolbox/sys_tools.py b/python_toolbox/sys_tools.py
@@ -6,10 +6,8 @@
 
 from __future__ import with_statement
 
-import os
 import sys
 import cStringIO
-import subprocess
 
 from python_toolbox.context_managers import (ContextManager,
                                                     BlankContextManager)
diff --git a/python_toolbox/version_info.py b/python_toolbox/version_info.py
@@ -28,9 +28,9 @@ class VersionInfo(tuple):
     _fields = ('major', 'minor', 'micro') 
 
     
-    def __new__(_cls, major, minor, micro):
+    def __new__(cls, major, minor, micro):
         '''Create new instance of `VersionInfo(major, minor, micro)`.'''
-        return tuple.__new__(_cls, (major, minor, micro)) 
+        return tuple.__new__(cls, (major, minor, micro)) 
 
     
     @classmethod
@@ -54,12 +54,12 @@ def _asdict(self):
         return OrderedDict(zip(self._fields, self)) 
 
     
-    def _replace(_self, **kwargs):
+    def _replace(self, **kwargs):
         '''
         Make a `VersionInfo` object replacing specified fields with new values.
         '''
         result = \
-            _self._make(map(kwargs.pop, ('major', 'minor', 'micro'),_self))
+            self._make(map(kwargs.pop, ('major', 'minor', 'micro'), self))
         if kwargs:
             raise ValueError('Got unexpected field names: %r' % kwargs.keys())
         return result 
diff --git a/python_toolbox/zip_tools.py b/python_toolbox/zip_tools.py
@@ -12,7 +12,7 @@
 import fnmatch
 
 
-def zip_folder(folder, zip_path, ignored_patterns=[]):
+def zip_folder(folder, zip_path, ignored_patterns=()):
     '''
     Zip `folder` into a zip file specified by `zip_path`.
     

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ def iterate(queue, block=False, limit_to_original_size=False,`
`50`	`50`	"`_prefetch_if_no_qsize=True` to have the entire queue "
`51`	`51`	`"prefetched before yielding the items."`
`52`	`52`	`)`
`53`		`- for i in xrange(queue.qsize()):`
	`53`	`+ for _ in xrange(queue.qsize()):`
`54`	`54`	`try:`
`55`	`55`	`yield queue.get(block=block)`
`56`	`56`	`except queue_module.Empty:`