Allows underscores in URL hosts

colinjeanne · colinjeanne · commit fa2593dad194 · 2017-04-07T20:17:31.000-07:00
Underscore is a valid character in the host portion of a URL but the simply URL validation regex does not currently support it. Ideally this would be using `urllib` or `urlparse` but since that module changed from 2 to 3 the simple fix is to just update the regex.
diff --git a/src/onelogin/saml2/settings.py b/src/onelogin/saml2/settings.py
@@ -33,7 +33,7 @@
 # Released under a BSD 3-Clause License
 url_regex = re.compile(
     r'^(?:[a-z0-9\.\-]*)://'  # scheme is validated separately
-    r'(?:(?:[A-Z0-9](?:[A-Z0-9-]{0,61}[A-Z0-9])?\.)+(?:[A-Z]{2,6}\.?|[A-Z0-9-]{2,}\.?)|'  # domain...
+    r'(?:(?:[A-Z0-9_](?:[A-Z0-9-_]{0,61}[A-Z0-9_])?\.)+(?:[A-Z]{2,6}\.?|[A-Z0-9-]{2,}\.?)|'  # domain...
     r'localhost|'  # localhost...
     r'\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}|'  # ...or ipv4
     r'\[?[A-F0-9]*:[A-F0-9:]+\]?)'  # ...or ipv6
