Merge pull request SAML-Toolkits#30 from macfound/master

pitbulk · web-flow · commit 4eec1a33a59c · 2016-10-18T18:58:03.000+02:00
signature checks didn't work
diff --git a/src/onelogin/saml2/response.py b/src/onelogin/saml2/response.py
@@ -199,10 +199,10 @@ def is_valid(self, request_data, request_id=None):
                 if not any_subject_confirmation:
                     raise Exception('A valid SubjectConfirmation was not found on this Response')
 
-                if security['wantAssertionsSigned'] and not not has_signed_assertion:
+                if security['wantAssertionsSigned'] and not has_signed_assertion:
                     raise Exception('The Assertion of the Response is not signed and the SP require it')
 
-                if security['wantMessagesSigned'] and has_signed_response:
+                if security['wantMessagesSigned'] and not has_signed_response:
                     raise Exception('The Message of the Response is not signed and the SP require it')
 
             if not signed_elements or (not has_signed_response and not has_signed_assertion):
