Skip to content

Commit 4a30dc5

Browse files
committed
Discourage the use of the fingerprint on production environments
1 parent 20e839d commit 4a30dc5

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

README.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,8 @@ Security warning
120120
In production, the **strict** parameter MUST be set as **"true"**. Otherwise
121121
your environment is not secure and will be exposed to attacks.
122122

123+
In production also we highly recommend to register on the settings the IdP certificate instead of using the fingerprint method. The fingerprint, is a hash, so at the end is open to a collision attack that can end on a signature validation bypass. Other SAML toolkits deprecated that mechanism, we maintain it for compatibility and also to be used on test environment.
124+
123125
Getting started
124126
---------------
125127

@@ -301,8 +303,11 @@ This is the settings.json file:
301303
// Public x509 certificate of the IdP
302304
"x509cert": "<onelogin_connector_cert>"
303305
/*
304-
* Instead of using the whole x509cert you can use a fingerprint in
305-
* order to validate a SAMLResponse.
306+
* Instead of using the whole x509cert you can use a fingerprint in order to
307+
* validate a SAMLResponse (but you still need the x509cert to validate LogoutRequest and LogoutResponse using the HTTP-Redirect binding).
308+
* But take in mind that the fingerprint, is a hash, so at the end is open to a collision attack that can end on a signature validation bypass,
309+
* that why we don't recommend it use for production environments.
310+
*
306311
* (openssl x509 -noout -fingerprint -in "idp.crt" to generate it,
307312
* or add for example the -sha256 , -sha384 or -sha512 parameter)
308313
*

0 commit comments

Comments
 (0)