fix pr feedback

mcodik · mcodik · commit d85290fd2c24 · 2018-07-30T13:50:27.000-04:00
diff --git a/events/next18/README.md b/events/next18/README.md
@@ -13,29 +13,32 @@ commandline tool that:
 ## Getting started
 
 * Follow the [Sheets API python quickstart](https://developers.google.com/sheets/api/quickstart/python)
-  * Make sure to save the `client-secrets.json` file in your working directory
+  * Make sure to save the `credentials.json` file in your working directory
 * Enable the Google Slides API, Google Drive API and Google Sheets API in your
   developer project
 * Run the tool with no arguments to complete the OAuth consent flow:
 
-<pre>
-    $ python qbr_tool.py
-</pre>
+```bash
+$ python qbr_tool.py
+```
 
 * Run the tool:
 
-<pre>
-    // Create the spreadsheet from the Google Slides template.
-    // For example, 13My9SxkotWssCc2F5yaXp2fzGrzoYV6maytr3qAT9GQ
-    $ python qbr_tool.py create_sheet --template_id &lt;your template id&gt;
-
-    // Add data from the stub customer service
-    $ python qbr_tool.py add_customers \
-        --spreadsheet_id &lt;your spreadsheet id&gt; \
-        --customer_id jupiter
-
-    // Generate the filled in presentation
-    $ python qbr_tool.py create_presentations
-         --spreadsheet_id &lt;your spreadsheet id&gt; \
-         --customer_id jupiter
-</pre>
+```bash
+# Create the spreadsheet from the Google Slides template.
+# For example, 13My9SxkotWssCc2F5yaXp2fzGrzoYV6maytr3qAT9GQ
+$ python qbr_tool.py create_sheet --template_id <your template id>;
+Spreadsheet URL: https://docs.google.com/spreadsheets/d/<spreadsheet id>
+
+# Add data from the stub customer service
+$ python qbr_tool.py add_customers \
+    --spreadsheet_id <spreadsheet id> \
+    --customer_id jupiter
+
+# Generate the filled in presentation
+$ python qbr_tool.py create_presentations
+    --spreadsheet_id <spreadsheet id> \
+    --customer_id jupiter
+jupiter: https://docs.google.com/presentations/d/<filled in presentation id>
+```
+
diff --git a/events/next18/customer_spreadsheet_reader.py b/events/next18/customer_spreadsheet_reader.py
@@ -38,8 +38,10 @@ def ReadColumnData(self, column_id):
     def ExecuteRead(self):
         filters = list(self._data_filters.values())
         get_body = {'dataFilters': filters}
-        read_fields = ('sheets.properties.sheetId,sheets.data.rowData.' +
-            'values.formattedValue,developerMetadata.metadataValue')
+        read_fields = ','.join([
+            'sheets.properties.sheetId',
+            'sheets.data.rowData.values.formattedValue',
+            'developerMetadata.metadataValue'])
         spreadsheet = self._sheets_service.spreadsheets().getByDataFilter(
             spreadsheetId=self._spreadsheet_id, body=get_body,
             fields=read_fields).execute()
@@ -66,9 +68,7 @@ def GetTemplateId(self):
     def GetColumnData(self, column_id):
         index = list(self._data_filters.keys()).index(column_id)
         data = self._spreadsheet.get('sheets')[0].get('data')[index]
-        values = []
-        for row in data.get('rowData'):
-            value = row.get('values')[0].get('formattedValue')
-            values.append(value)
+        values = [row.get('values')[0].get('formattedValue')
+                  for row in data.get('rowData')]
         # Remove the first value which is just the label
         return values[1:]
diff --git a/events/next18/spreadsheet_writer.py b/events/next18/spreadsheet_writer.py
@@ -62,8 +62,8 @@ def InsertColumn(self, sheet_id, column_index):
                    'endIndex': column_index + 1,
                 },
              }
-          }
-          self._requests.append(request)
+        }
+        self._requests.append(request)
 
     def PopulateColumn(self, sheet_id, column_index, column_id, values):
         # Include the column ID in the column values
