Skip to content

Commit 9b210a6

Browse files
committed
Minor refactor: pull out a common method for oneof's and use string .format().
1 parent 203d11c commit 9b210a6

File tree

1 file changed

+18
-12
lines changed

1 file changed

+18
-12
lines changed

drive/activity-v2/quickstart.py

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,7 @@ def main():
2424

2525
# Call the Drive Activity API
2626
results = service.activity().query(body={
27-
'pageSize': 10,
28-
'consolidationStrategy': {
29-
'legacy': {}
30-
}
27+
'pageSize': 10
3128
}).execute()
3229
activities = results.get('activities', [])
3330

@@ -47,7 +44,13 @@ def main():
4744
def truncated(array, limit=2):
4845
contents = ', '.join(array[:limit])
4946
more = '' if len(array) <= limit else ', ...'
50-
return '[' + contents + more + ']'
47+
return u'[{0}{1}]'.format(contents, more)
48+
49+
50+
def getOneOf(object):
51+
for key in object:
52+
return key
53+
return 'unknown'
5154

5255

5356
def getTimeInfo(activity):
@@ -59,32 +62,35 @@ def getTimeInfo(activity):
5962

6063

6164
def getActionInfo(actionDetail):
62-
return next(iter(actionDetail))
65+
return getOneOf(actionDetail)
6366

6467

6568
def getUserInfo(user):
6669
if 'knownUser' in user:
6770
knownUser = user['knownUser']
6871
isMe = knownUser.get('isCurrentUser', False)
6972
return u'people/me' if isMe else knownUser['personName']
70-
return next(iter(user))
73+
return getOneOf(user)
7174

7275

7376
def getActorInfo(actor):
7477
if 'user' in actor:
7578
return getUserInfo(actor['user'])
76-
return next(iter(actor))
79+
return getOneOf(actor)
7780

7881

7982
def getTargetInfo(target):
8083
if 'driveItem' in target:
81-
return 'driveItem:"' + target['driveItem'].get('title', 'unknown') + '"'
84+
title = target['driveItem'].get('title', 'unknown')
85+
return 'driveItem:"{0}"'.format(title)
8286
if 'teamDrive' in target:
83-
return 'teamDrive:"' + target['teamDrive'].get('title', 'unknown') + '"'
87+
title = target['teamDrive'].get('title', 'unknown')
88+
return 'teamDrive:"{0}"'.format(title)
8489
if 'fileComment' in target:
8590
parent = target['fileComment'].get('parent', {})
86-
return 'fileComment:"' + parent.get('title', 'unknown') + '"'
87-
return next(iter(target))
91+
title = parent.get('title', 'unknown')
92+
return 'fileComment:"{0}"'.format(title)
93+
return '{0}:unknown'.format(getOneOf(target))
8894

8995

9096
if __name__ == '__main__':

0 commit comments

Comments
 (0)