improving error handling

peterlai · peterlai · commit a576f417d6b9 · 2016-02-29T19:57:52.000-08:00
diff --git a/quickbooks/client.py b/quickbooks/client.py
@@ -206,8 +206,11 @@ def make_request(self, request_type, url, request_body=None, content_type='appli
         except:
             raise QuickbooksException("Error reading json response: {0}".format(req.text), 10000)
 
-        if req.status_code is not httplib.OK or "Fault" in result:
+        if "Fault" in result:
             self.handle_exceptions(result["Fault"])
+        elif not req.status_code == httplib.OK:
+            raise QuickbooksException("Error returned with status code '{0}': {1}".format(
+                req.status_code, req.text), 10000)
         else:
             return result
 
