Update TxnTaxDetail to QuickbooksBaseObject and changed default of TxnSource to None.

ej2 · ej2 · commit 9bbe69502936 · 2016-06-15T21:20:05.000-05:00
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -1,6 +1,14 @@
 Changelog
 ========
 
+* 0.3.13 (June 15, 2016)
+    * Fixed issue with PurchaseEx on Purchase
+    * Added missing object names to isvalid_object_name.
+    * Removed CompanyInfo from object names used by isvalid_object_name.
+    * Changed default of TxnSource to None on the following objects: Deposit, Purchase, RefundReceipt, and Transfer.
+    * Changed TxnTaxDetail from a QuickbooksManagedObject to a QuickbooksBaseObject.
+
+
 * 0.3.13 (May 18, 2016)
     * Added option to enable or disable singeton pattern (it defaults to disabled).
     * Improved error handling.
diff --git a/quickbooks/client.py b/quickbooks/client.py
@@ -43,7 +43,7 @@ class QuickBooks(object):
 
     _BUSINESS_OBJECTS = [
         "Account", "Attachable", "Bill", "BillPayment",
-        "Class", "CompanyInfo", "CreditMemo", "Customer",
+        "Class", "CreditMemo", "Customer",
         "Department", "Deposit", "Employee", "Estimate", "Invoice",
         "Item", "JournalEntry", "Payment", "PaymentMethod",
         "Purchase", "PurchaseOrder", "RefundReceipt",
diff --git a/quickbooks/objects/deposit.py b/quickbooks/objects/deposit.py
@@ -118,7 +118,7 @@ def __init__(self):
         self.GlobalTaxCalculation = "TaxExcluded"
         self.PrivateNote = ""
         self.TxnStatus = ""
-        self.TxnSource = ""
+        self.TxnSource = None
 
         self.DepositToAccountRef = None
         self.DepartmentRef = None
diff --git a/quickbooks/objects/purchase.py b/quickbooks/objects/purchase.py
@@ -127,7 +127,7 @@ def __init__(self):
         self.TotalAmt = 0
         self.PrintStatus = "NeedToPrint"
         self.PurchaseEx = None
-        self.TxnSource = ""
+        self.TxnSource = None
         self.GlobalTaxCalculation = "TaxExcluded"
 
         self.TxnTaxDetail = None
diff --git a/quickbooks/objects/refundreceipt.py b/quickbooks/objects/refundreceipt.py
@@ -47,7 +47,7 @@ def __init__(self):
         self.PaymentType = ""
         self.CheckPayment = ""
         self.CreditCardPayment = ""
-        self.TxnSource = ""
+        self.TxnSource = None
         self.GlobalTaxCalculation = "TaxExcluded"
 
         self.DepartmentRef = None
diff --git a/quickbooks/objects/tax.py b/quickbooks/objects/tax.py
@@ -34,7 +34,7 @@ def __str__(self):
 
 
 @python_2_unicode_compatible
-class TxnTaxDetail(QuickbooksManagedObject):
+class TxnTaxDetail(QuickbooksBaseObject):
     class_dict = {
         "TxnTaxCodeRef": Ref,
     }
diff --git a/quickbooks/objects/transfer.py b/quickbooks/objects/transfer.py
@@ -20,7 +20,7 @@ def __init__(self):
         self.Amount = 0
         self.TxnDate = ""
         self.PrivateNote = ""
-        self.TxnSource = ""
+        self.TxnSource = None
 
         self.FromAccountRef = None
         self.ToAccountRef = None

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ def __str__(self):`
`34`	`34`
`35`	`35`
`36`	`36`	`@python_2_unicode_compatible`
`37`		`-class TxnTaxDetail(QuickbooksManagedObject):`
	`37`	`+class TxnTaxDetail(QuickbooksBaseObject):`
`38`	`38`	`class_dict = {`
`39`	`39`	`"TxnTaxCodeRef": Ref,`
`40`	`40`	`}`