Skip to content

Commit cb83dbd

Browse files
committed
Avoid tox_install.sh for constraints support
We do not need tox_install.sh, pip can handle constraints itself and install the project correctly. Thus update tox.ini and remove the now obsolete tools/tox_install.sh file. This follows https://review.openstack.org/#/c/508061 to remove tools/tox_install.sh. Change-Id: I7f06c0be47f57a9c1ee3cadc7328b1b1b138b3cd (cherry picked from commit aede01a)
1 parent b481c10 commit cb83dbd

File tree

2 files changed

+5
-38
lines changed

2 files changed

+5
-38
lines changed

tools/tox_install.sh

Lines changed: 0 additions & 30 deletions
This file was deleted.

tox.ini

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@ whitelist_externals = find
1111
bash
1212
passenv = ZUUL_CACHE_DIR
1313
REQUIREMENTS_PIP_LOCATION
14-
install_command = {toxinidir}/tools/tox_install.sh {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h=stable/pike} {opts} {packages}
15-
setenv = VIRTUAL_ENV={envdir}
16-
BRANCH_NAME=master
17-
CLIENT_NAME=python-novaclient
18-
19-
deps = -r{toxinidir}/test-requirements.txt
14+
install_command = pip install {opts} {packages}
15+
deps =
16+
-c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h=stable/pike}
17+
-r{toxinidir}/test-requirements.txt
18+
-r{toxinidir}/requirements.txt
2019
commands =
2120
find . -type f -name "*.pyc" -delete
2221
bash tools/pretty_tox.sh '{posargs}'
@@ -44,15 +43,13 @@ commands = sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasen
4443
basepython = python2.7
4544
passenv = OS_NOVACLIENT_TEST_NETWORK
4645
setenv =
47-
{[testenv]setenv}
4846
OS_TEST_PATH = ./novaclient/tests/functional
4947
commands = bash tools/pretty_tox.sh '--concurrency=1 {posargs}'
5048

5149
[testenv:functional-py35]
5250
basepython = python3.5
5351
passenv = OS_NOVACLIENT_TEST_NETWORK
5452
setenv =
55-
{[testenv]setenv}
5653
OS_TEST_PATH = ./novaclient/tests/functional
5754
commands = bash tools/pretty_tox.sh '--concurrency=1 {posargs}'
5855

0 commit comments

Comments
 (0)