Adding fixtures for notification test to bring parity with Ruby library.

jkeyes · jkeyes · commit f994b8cdd729 · 2015-03-17T23:00:21.000Z
diff --git a/intercom/lib/typed_json_deserializer.py b/intercom/lib/typed_json_deserializer.py
@@ -32,6 +32,8 @@ def deserialize(self):
             return self.deserialize_object(self._json)
 
     def deserialize_collection(self, collection_json):
+        if collection_json is None:
+            return []
         return [JsonDeserializer(object_json).deserialize()
                 for object_json in collection_json]
 
diff --git a/tests/unit/notification_spec.py b/tests/unit/notification_spec.py
@@ -22,10 +22,19 @@ def it_returns_correct_user_notification_topic(self):
         payload = Notification(**test_user_notification)
         expect(payload.topic) == "user.created"
 
+    def it_returns_instance_of_user(self):
+        User = create_class_instance('User')  # noqa
+        payload = Notification(**test_user_notification)
+        expect(payload.model).to.be_instance_of(User.__class__)
+
     def it_returns_instance_of_conversation(self):
         Conversation = create_class_instance('Conversation')
         payload = Notification(**test_conversation_notification)
         expect(payload.model).to.be_instance_of(Conversation.__class__)
+
+    def it_returns_correct_model_type_for_conversation(self):
+        Conversation = create_class_instance('Conversation')
+        payload = Notification(**test_conversation_notification)
         expect(payload.model_type) == Conversation.__class__
 
     def it_returns_correct_conversation_notification_topic(self):
@@ -36,3 +45,25 @@ def it_returns_inner_user_object_for_conversation(self):
         User = create_class_instance('User')
         payload = Notification(**test_conversation_notification)
         expect(payload.model.user).to.be_instance_of(User.__class__)
+
+    def it_returns_inner_user_object_with_nil_tags(self):
+        user_notification = {
+            "type": "notification_event",
+            "app_id": "aa11aa",
+            "data": {
+                "type": "notification_event_data",
+                "item": {
+                    "type": "user",
+                    "id": "abc123def",
+                    "user_id": "666",
+                    "email": "joe@example.com",
+                    "name": "Joe",
+                    "tags": {
+                        "type": "tag.list",
+                        "tags": None
+                    }
+                }
+            }
+        }
+        payload = Notification(**user_notification)
+        expect(payload.model.tags) == []
