Commit 91693e1
committed
Fixed a bug which prevented User.delete() from working.
Intercom._call was not expecting the DELETE method when constructing request data parameters.
Hence, the params were being skipped over and the request didn't correctly register with Intercom's API.
Added in intergration test to check this is working as indetented.
Before,
The user returned would be the 'bob@example.com' not the email specificed ('to-delete@example.com' in the tests case).
Now,
The user info returned corresponds to the email specified ('to-delete@example.com') as we would expect, as Intercom API 'Returns the deleted user on success' (as according to their docs).1 parent 35c6396 commit 91693e1
2 files changed
+5
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
29 | 33 | | |
30 | 34 | | |
31 | 35 | | |
| |||
0 commit comments