dont ask for id attr if this is *Manager originating custom action

kkoralsky · kkoralsky · commit adb63054add3 · 2019-04-24T11:49:22.000+02:00
diff --git a/gitlab/v4/cli.py b/gitlab/v4/cli.py
@@ -217,14 +217,14 @@ def _populate_sub_parser_by_class(cls, sub_parser):
                  for x in mgr_cls._from_parent_attrs]
                 sub_parser_action.add_argument("--sudo", required=False)
 
+            required, optional, needs_id = cli.custom_actions[name][action_name]
             # We need to get the object somehow
-            if gitlab.mixins.GetWithoutIdMixin not in inspect.getmro(cls):
+            if needs_id and gitlab.mixins.GetWithoutIdMixin not in inspect.getmro(cls):
                 if cls._id_attr is not None:
                     id_attr = cls._id_attr.replace('_', '-')
                     sub_parser_action.add_argument("--%s" % id_attr,
                                                    required=True)
 
-            required, optional, dummy = cli.custom_actions[name][action_name]
             [sub_parser_action.add_argument("--%s" % x.replace('_', '-'),
                                             required=True)
              for x in required if x != cls._id_attr]
