Skip to content

Commit ca899c8

Browse files
author
A. Jesse Jiryu Davis
committed
thread_util.have_gevent is more accurate than has_greenlets now
Pool(use_greenlets=True) now requires Gevent, not just greenlet
1 parent 0de9e59 commit ca899c8

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

pymongo/pool.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,9 @@ def __init__(self, pair, max_size, net_timeout, conn_timeout, use_ssl,
142142
- `wait_queue_multiple`: (integer) Multiplied by max_pool_size to give
143143
the number of threads allowed to wait for a socket at one time.
144144
"""
145-
if use_greenlets and not thread_util.have_greenlet:
145+
if use_greenlets and not thread_util.have_gevent:
146146
raise ConfigurationError(
147-
"The greenlet module is not available. "
147+
"The Gevent module is not available. "
148148
"Install the greenlet package from PyPI."
149149
)
150150

pymongo/thread_util.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@
2222
except ImportError:
2323
from time import time as _time
2424

25-
have_greenlet = True
25+
have_gevent = True
2626
try:
2727
import greenlet
2828
import gevent.coros
2929
import gevent.thread
3030
except ImportError:
31-
have_greenlet = False
31+
have_gevent = False
3232

3333

3434
# Do we have to work around http://bugs.python.org/issue1868?
@@ -264,7 +264,7 @@ def __init__(self, value=1, max_waiters=1):
264264
self, BoundedSemaphore, value, max_waiters)
265265

266266

267-
if have_greenlet:
267+
if have_gevent:
268268
class MaxWaitersBoundedSemaphoreGevent(MaxWaitersBoundedSemaphore):
269269
def __init__(self, value=1, max_waiters=1):
270270
MaxWaitersBoundedSemaphore.__init__(

test/test_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ def test_getters(self):
143143

144144
def test_use_greenlets(self):
145145
self.assertFalse(MongoClient(host, port).use_greenlets)
146-
if thread_util.have_greenlet:
146+
if thread_util.have_gevent:
147147
self.assertTrue(
148148
MongoClient(
149149
host, port, use_greenlets=True).use_greenlets)

test/test_master_slave_connection.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def test_types(self):
7979
def test_use_greenlets(self):
8080
self.assertFalse(self.client.use_greenlets)
8181

82-
if thread_util.have_greenlet:
82+
if thread_util.have_gevent:
8383
master = MongoClient(host, port, use_greenlets=True)
8484
slaves = [
8585
MongoClient(slave.host, slave.port, use_greenlets=True)

test/test_thread_util.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
from nose.plugins.skip import SkipTest
2626

2727
from pymongo import thread_util
28-
if thread_util.have_greenlet:
28+
if thread_util.have_gevent:
2929
import greenlet
3030

3131
from test.utils import looplet, RendezvousThread
@@ -148,7 +148,7 @@ def test_thread_ident(self):
148148
self._test_ident(False)
149149

150150
def test_greenlet_ident(self):
151-
if not thread_util.have_greenlet:
151+
if not thread_util.have_gevent:
152152
raise SkipTest('greenlet not installed')
153153

154154
self._test_ident(True)
@@ -212,7 +212,7 @@ def test_thread_counter(self):
212212
self._test_counter(False)
213213

214214
def test_greenlet_counter(self):
215-
if not thread_util.have_greenlet:
215+
if not thread_util.have_gevent:
216216
raise SkipTest('greenlet not installed')
217217

218218
self._test_counter(True)

0 commit comments

Comments
 (0)