PYTHON-939 - AttributeError during shutdown.

ajdavis · ajdavis · commit c226b4fb939f · 2015-06-16T20:28:59.000-04:00
I was treating a weakref.ref as if it were a weakref.proxy.
diff --git a/pymongo/periodic_executor.py b/pymongo/periodic_executor.py
@@ -135,16 +135,16 @@ def _shutdown_executors():
 
     # First signal all executors to close...
     for ref in executors:
-        try:
-            ref().close()
-        except ReferenceError:
-            pass
+        executor = ref()
+        if executor:
+            executor.close()
 
     # ...then try to join them.
     for ref in executors:
-        try:
-            ref().join(1)
-        except ReferenceError:
-            pass
+        executor = ref()
+        if executor:
+            executor.join(1)
+
+    executor = None
 
 atexit.register(_shutdown_executors)
