PYTHON-870 - Fix two unlikely reference leaks.

behackett · behackett · commit 76530ccd724a · 2015-03-26T13:00:40.000-07:00
diff --git a/bson/_cbsonmodule.c b/bson/_cbsonmodule.c
@@ -385,6 +385,7 @@ static int _load_python_objects(PyObject* module) {
 
     if (_load_object(&re_compile, "re", "compile")) {
         state->REType = NULL;
+        Py_DECREF(empty_string);
         return 1;
     }
 
@@ -2129,6 +2130,7 @@ static PyObject* get_value(PyObject* self, const char* buffer,
             if (!bson_int64_type)
                 goto invalid;
             if (max < 8) {
+                Py_DECREF(bson_int64_type);
                 goto invalid;
             }
             memcpy(&ll, buffer + *position, 8);

Original file line number	Diff line number	Diff line change
`@@ -385,6 +385,7 @@ static int _load_python_objects(PyObject* module) {`
`385`	`385`
`386`	`386`	`if (_load_object(&re_compile, "re", "compile")) {`
`387`	`387`	`state->REType = NULL;`
	`388`	`+ Py_DECREF(empty_string);`
`388`	`389`	`return 1;`
`389`	`390`	`}`
`390`	`391`
`@@ -2129,6 +2130,7 @@ static PyObject* get_value(PyObject* self, const char* buffer,`
`2129`	`2130`	`if (!bson_int64_type)`
`2130`	`2131`	`goto invalid;`
`2131`	`2132`	`if (max < 8) {`
	`2133`	`+ Py_DECREF(bson_int64_type);`
`2132`	`2134`	`goto invalid;`
`2133`	`2135`	`}`
`2134`	`2136`	`memcpy(&ll, buffer + *position, 8);`