Skip to content

Commit 51cadce

Browse files
committed
PYTHON-915 - More robust tests.
1 parent f506d8b commit 51cadce

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

test/test_mongos_load_balancing.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,20 +149,20 @@ def test_local_threshold(self):
149149
writable_addresses(topology))
150150

151151
# No error
152-
client.db.collection.find_one()
152+
client.admin.command('ismaster')
153153

154154
client = connected(self.mock_client(localThresholdMS=0))
155155
self.assertEqual(0, client.local_threshold_ms)
156156
# No error
157-
client.db.collection.find_one()
157+
client.db.command('ismaster')
158158
# Our chosen mongos goes down.
159159
client.kill_host('%s:%s' % next(iter(client.nodes)))
160160
try:
161-
client.db.collection.find_one()
161+
client.db.command('ismaster')
162162
except:
163163
pass
164164
# No error
165-
client.db.collection.find_one()
165+
client.db.command('ismaster')
166166

167167
def test_load_balancing(self):
168168
# Although the server selection JSON tests already prove that

test/test_read_preferences.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
unittest,
4545
db_user,
4646
db_pwd)
47-
from test.utils import single_client, one, wait_until, rs_client
47+
from test.utils import connected, single_client, one, wait_until, rs_client
4848
from test.version import Version
4949

5050

@@ -220,7 +220,11 @@ def test_zero_latency(self):
220220
for ping_time, host in zip(ping_times, self.client.nodes):
221221
ServerDescription._host_to_round_trip_time[host] = ping_time
222222
try:
223-
client = rs_client(readPreference='nearest', localThresholdMS=0)
223+
client = connected(
224+
rs_client(readPreference='nearest', localThresholdMS=0))
225+
wait_until(
226+
lambda: client.nodes == self.client.nodes,
227+
"discovered all nodes")
224228
host = self.read_from_which_host(client)
225229
for _ in range(5):
226230
self.assertEqual(host, self.read_from_which_host(client))

0 commit comments

Comments
 (0)