Drop unnecessary guards around _strptime calls

bgilbert · bgilbert · commit e7b3614e8373 · 2014-04-09T22:01:09.000-04:00
diff --git a/github3/auths.py b/github3/auths.py
@@ -48,13 +48,9 @@ def __init__(self, auth, session=None):
         self.id = auth.get('id', 0)
         self._api = self._build_url('authorizations', str(self.id))
         #: datetime object representing when the authorization was created.
-        self.created_at = None
-        if auth.get('created_at'):
-            self.created_at = self._strptime(auth.get('created_at'))
+        self.created_at = self._strptime(auth.get('created_at'))
         #: datetime object representing when the authorization was created.
-        self.updated_at = None
-        if auth.get('updated_at'):
-            self.updated_at = self._strptime(auth.get('updated_at'))
+        self.updated_at = self._strptime(auth.get('updated_at'))
 
     def __repr__(self):
         return '<Authorization [{0}]>'.format(self.name)
diff --git a/github3/issues/issue.py b/github3/issues/issue.py
@@ -48,9 +48,7 @@ def __init__(self, issue, session=None):
 
         # If an issue is still open, this field will be None
         #: datetime object representing when the issue was closed.
-        self.closed_at = None
-        if issue.get('closed_at'):
-            self.closed_at = self._strptime(issue.get('closed_at'))
+        self.closed_at = self._strptime(issue.get('closed_at'))
 
         #: Number of comments on this issue.
         self.comments = issue.get('comments')
diff --git a/github3/issues/milestone.py b/github3/issues/milestone.py
@@ -36,9 +36,7 @@ def __init__(self, mile, session=None):
         #: datetime object representing when the milestone was created.
         self.created_at = self._strptime(mile.get('created_at'))
         #: datetime representing when this milestone is due.
-        self.due_on = None
-        if mile.get('due_on'):
-            self.due_on = self._strptime(mile.get('due_on'))
+        self.due_on = self._strptime(mile.get('due_on'))
         #: datetime object representing when the milestone was updated.
         self.updated_at = self._strptime(mile.get('updated_at'))
 
diff --git a/github3/models.py b/github3/models.py
@@ -310,9 +310,7 @@ def __init__(self, acct, session):
         self.company = acct.get('company', '')
 
         #: datetime object representing the date the account was created
-        self.created_at = None
-        if acct.get('created_at'):
-            self.created_at = self._strptime(acct.get('created_at'))
+        self.created_at = self._strptime(acct.get('created_at'))
 
         #: E-mail address of the user/org
         self.email = acct.get('email')
diff --git a/github3/notifications.py b/github3/notifications.py
@@ -49,9 +49,7 @@ def __init__(self, notif, session=None):
         #: Dictionary of urls for the thread
         self.urls = notif.get('urls')
         #: datetime object representing the last time the user read the thread
-        self.last_read_at = notif.get('last_read_at')
-        if self.last_read_at:
-            self.last_read_at = self._strptime(self.last_read_at)
+        self.last_read_at = self._strptime(notif.get('last_read_at'))
         #: The reason you're receiving the notification
         self.reason = notif.get('reason')
         #: Subject of the Notification, e.g., which issue/pull/diff is this in
diff --git a/github3/pulls.py b/github3/pulls.py
@@ -112,10 +112,8 @@ def __init__(self, pull, session=None):
         #: Number of deletions on this pull request
         self.deletions = pull.get('deletions')
 
-        closed = pull.get('closed_at')
-        # If the pull request has been closed
         #: datetime object representing when the pull was closed
-        self.closed_at = self._strptime(closed) if closed else None
+        self.closed_at = self._strptime(pull.get('closed_at'))
         #: Number of comments
         self.comments = pull.get('comments')
         #: Comments url (not a template)
@@ -162,9 +160,7 @@ def __init__(self, pull, session=None):
         }
 
         #: datetime object representing when the pull was merged
-        merged = pull.get('merged_at')
-        # If the pull request has been merged
-        self.merged_at = self._strptime(merged) if merged else None
+        self.merged_at = self._strptime(pull.get('merged_at'))
         #: Whether the pull is deemed mergeable by GitHub
         self.mergeable = pull.get('mergeable', False)
         #: Whether it would be a clean merge or not
diff --git a/github3/repos/comment.py b/github3/repos/comment.py
@@ -41,9 +41,7 @@ def __init__(self, comment, session=None):
         #: The position in the diff where the comment was made.
         self.position = comment.get('position')
         #: datetime object representing when the comment was updated.
-        self.updated_at = comment.get('updated_at')
-        if self.updated_at:
-            self.updated_at = self._strptime(self.updated_at)
+        self.updated_at = self._strptime(comment.get('updated_at'))
         #: Login of the user who left the comment.
         self.user = None
         if comment.get('user'):
diff --git a/github3/repos/deployment.py b/github3/repos/deployment.py
@@ -30,14 +30,10 @@ def __init__(self, deployment, session=None):
         self.payload = deployment.get('payload')
 
         #: Date the Deployment was created
-        self.created_at = deployment.get('created_at')
-        if self.created_at:
-            self.created_at = self._strptime(self.created_at)
+        self.created_at = self._strptime(deployment.get('created_at'))
 
         #: Date the Deployment was updated
-        self.updated_at = deployment.get('updated_at')
-        if self.updated_at:
-            self.updated_at = self._strptime(self.updated_at)
+        self.updated_at = self._strptime(deployment.get('updated_at'))
 
         #: Description of the deployment
         self.description = deployment.get('description')
@@ -112,14 +108,10 @@ def __init__(self, status, session=None):
         self.target_url = status.get('target_url')
 
         #: Date the deployment status was created
-        self.created_at = status.get('created_at')
-        if self.created_at:
-            self.created_at = self._strptime(self.created_at)
+        self.created_at = self._strptime(status.get('created_at'))
 
         #: Date the deployment status was updated
-        self.updated_at = status.get('updated_at')
-        if self.updated_at:
-            self.updated_at = self._strptime(self.updated_at)
+        self.updated_at = self._strptime(status.get('updated_at'))
 
         #: Description of the deployment
         self.description = status.get('description')
diff --git a/github3/repos/hook.py b/github3/repos/hook.py
@@ -33,9 +33,7 @@ def __init__(self, hook, session=None):
         super(Hook, self).__init__(hook, session)
         self._api = hook.get('url', '')
         #: datetime object representing when this hook was last updated.
-        self.updated_at = None
-        if hook.get('updated_at'):
-            self.updated_at = self._strptime(hook.get('updated_at'))
+        self.updated_at = self._strptime(hook.get('updated_at'))
         #: datetime object representing the date the hook was created.
         self.created_at = self._strptime(hook.get('created_at'))
         #: The name of the hook.
diff --git a/github3/repos/status.py b/github3/repos/status.py
@@ -33,9 +33,7 @@ def __init__(self, status):
         #: URL to view more information about the status
         self.target_url = status.get('target_url')
         #: datetime object representing the last time the status was updated
-        self.updated_at = None
-        if status.get('updated_at'):
-            self.updated_at = self._strptime(status.get('updated_at'))
+        self.updated_at = self._strptime(status.get('updated_at'))
 
     def __repr__(self):
         return '<Status [{s.id}:{s.state}]>'.format(s=self)
