Skip to content

Commit d37b92b

Browse files
committed
Finish updating issues module
1 parent 106e0a3 commit d37b92b

3 files changed

Lines changed: 6 additions & 18 deletions

File tree

github3/issues/issue.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ class Issue(GitHubCore):
3131
3232
"""
3333

34-
def __init__(self, issue, session=None):
35-
super(Issue, self).__init__(issue, session)
34+
def _update_attributes(self, issue):
3635
self._api = issue.get('url', '')
3736
#: :class:`User <github3.users.User>` representing the user the issue
3837
#: was assigned to.
@@ -100,9 +99,6 @@ def _repr(self):
10099
return '<Issue [{r[0]}/{r[1]} #{n}]>'.format(r=self.repository,
101100
n=self.number)
102101

103-
def _update_(self, issue):
104-
self.__init__(issue, self.session)
105-
106102
@requires_auth
107103
def add_labels(self, *args):
108104
"""Add labels to this issue.
@@ -210,7 +206,7 @@ def edit(self, title=None, body=None, assignee=None, state=None,
210206
data['milestone'] = None
211207
json = self._json(self._patch(self._api, data=dumps(data)), 200)
212208
if json:
213-
self._update_(json)
209+
self._update_attributes(json)
214210
return True
215211
return False
216212

github3/issues/label.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ class Label(GitHubCore):
1212
1313
See also: http://developer.github.com/v3/issues/labels/
1414
"""
15-
def __init__(self, label, session=None):
16-
super(Label, self).__init__(label, session)
15+
def _update_attributes(self, label):
1716
self._api = label.get('url', '')
1817
#: Color of the label, e.g., 626262
1918
self.color = label.get('color')
@@ -28,9 +27,6 @@ def _repr(self):
2827
def __str__(self):
2928
return self.name
3029

31-
def _update_(self, label):
32-
self.__init__(label, self.session)
33-
3430
@requires_auth
3531
def delete(self):
3632
"""Delete this label.
@@ -56,7 +52,7 @@ def update(self, name, color):
5652
'name': name, 'color': color})), 200)
5753

5854
if json:
59-
self._update_(json)
55+
self._update_attributes(json)
6056
return True
6157

6258
return False

github3/issues/milestone.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ class Milestone(GitHubCore):
1414
1515
See also: http://developer.github.com/v3/issues/milestones/
1616
"""
17-
def __init__(self, mile, session=None):
18-
super(Milestone, self).__init__(mile, session)
17+
def _update_attributes(self, mile):
1918
self._api = mile.get('url', '')
2019
#: Identifying number associated with milestone.
2120
self.number = mile.get('number')
@@ -46,9 +45,6 @@ def _repr(self):
4645
def __str__(self):
4746
return self.title
4847

49-
def _update_(self, mile):
50-
self.__init__(mile, self.session)
51-
5248
@requires_auth
5349
def delete(self):
5450
"""Delete this milestone.
@@ -94,6 +90,6 @@ def update(self, title=None, state=None, description=None, due_on=None):
9490
if data:
9591
json = self._json(self._patch(self._api, data=dumps(data)), 200)
9692
if json:
97-
self._update_(json)
93+
self._update_attributes(json)
9894
return True
9995
return False

0 commit comments

Comments
 (0)