|
| 1 | +Guidelines for Contributing to github3.py |
| 2 | +========================================= |
| 3 | + |
| 4 | +1. Regardless of the magnitude your pull request (a couple lines to a couple |
| 5 | + hundred lines), please add your name to the AUTHORS.rst file under the |
| 6 | + heading Contributors. |
| 7 | + |
| 8 | +2. If you're fixing a bug, please write a regression test. All the tests are |
| 9 | + structured like so:: |
| 10 | + |
| 11 | + tests/ |
| 12 | + - test_<module_name>.py |
| 13 | + + Test<ClassName> |
| 14 | + - def test_function_or_attribute |
| 15 | + |
| 16 | + Please do not add your regression test to an existing test, but create a |
| 17 | + new one. You can use the form ``test_issue_<number>``. In a docstring add |
| 18 | + the link and a short description of the regression issue. For example, if |
| 19 | + you found a bug in the class ``Issue``, write your test in the file |
| 20 | + ``test_issues.py`` in the class ``TestIssue``. You can place the new test |
| 21 | + in any order, e.g., below all the existing tests, near a related one, &c. |
| 22 | + |
| 23 | +3. If you're adding a new section of the API that does not already exist, |
| 24 | + please also add tests to the test suite. |
| 25 | + |
| 26 | +4. If you're adding additional functionality beyond what the API covers, |
| 27 | + please open an issue reqeust first and of course add tests to cover the |
| 28 | + functionality in the event it is accepted. |
| 29 | + |
| 30 | +5. In case you haven't caught on, for anything you add, write tests. |
| 31 | + |
| 32 | +6. Be cordial_. |
| 33 | + |
| 34 | +7. Rebase your fork/branch if needed and possible before submitting a pull |
| 35 | + request. This makes my life easier. If you honestly have no idea what I'm |
| 36 | + talking about, don't worry, I'll take care of it. |
| 37 | + |
| 38 | +.. links |
| 39 | +.. _cordial: http://kennethreitz.com/be-cordial-or-be-on-your-way.html |
0 commit comments