One-liner to add a 'since' parameter to iter_all_repos (github had it,

dwpachura · dwpachura · commit bc0c38133b5c · 2013-03-28T16:21:38.000-04:00
I needed it to avoid spending days rerunning after bugfixes).
diff --git a/AUTHORS.rst b/AUTHORS.rst
@@ -36,4 +36,6 @@ Contributors
 
 - Malcolm Box (@mbox)
 
-- Tom Petr (@tpetr)
+- Tom Petr (@tpetr)
+
+- David Pachura (@detenebrator)
diff --git a/github3/github.py b/github3/github.py
@@ -327,17 +327,20 @@ def issue(self, owner, repository, number):
             return repo.issue(number)
         return None
 
-    def iter_all_repos(self, number=-1, etag=None):
+    def iter_all_repos(self, number=-1, since=None, etag=None):
         """Iterate over every repository in the order they were created.
 
         :param int number: (optional), number of repositories to return.
             Default: -1, returns all of them
+        :param int since: (optional), last repository id seen (allows
+            restarting this iteration)
         :param str etag: (optional), ETag from a previous request to the same
             endpoint
         :returns: generator of :class:`Repository <github3.repos.Repository>`
         """
         url = self._build_url('repositories')
-        return self._iter(int(number), url, Repository, etag=etag)
+        params = {'since': since} if since else None
+        return self._iter(int(number), url, Repository, params=params, etag=etag)
 
     def iter_all_users(self, number=-1, etag=None):
         """Iterate over every user in the order they signed up for GitHub.
diff --git a/setup.py b/setup.py
@@ -10,6 +10,7 @@
     "github3",
     "github3.gists",
     "github3.repos",
+    "github3.issues",
 ]
 
 try:
diff --git a/tests/test_github.py b/tests/test_github.py
@@ -212,6 +212,14 @@ def test_iter_all_repos(self):
         expect(repo).isinstance(github3.repos.Repository)
         self.mock_assertions()
 
+        self.response('repo', _iter=True)
+        self.get('https://api.github.com/repositories')
+        self.conf.update(params={'since': 100000})
+        repo = next(self.g.iter_all_repos(since=100000))
+        expect(repo).isinstance(github3.repos.Repository)
+        assert(repo.id > 100000)
+        self.mock_assertions()
+
     def test_iter_all_users(self):
         self.response('user', _iter=True)
         self.get('https://api.github.com/users')

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`"github3",`
`11`	`11`	`"github3.gists",`
`12`	`12`	`"github3.repos",`
	`13`	`+ "github3.issues",`
`13`	`14`	`]`
`14`	`15`
`15`	`16`	`try:`