Add unit test for User#email_addresses

sigmavirus24 · sigmavirus24 · commit b75176989f68 · 2015-12-19T13:12:17.000-06:00
Remove test in old-style tests

Fix docstring and repr
diff --git a/github3/users.py b/github3/users.py
@@ -122,7 +122,7 @@ def _update_attributes(self, email):
         self.primary = email.get('primary')
 
     def _repr(self):
-        return '<UserEmail [{0}]>'.format(self.email)
+        return '<Email [{0}]>'.format(self.email)
 
     def __str__(self):
         return self.email
@@ -264,8 +264,7 @@ def delete_email_addresses(self, addresses=[]):
 
     @requires_auth
     def email_addresses(self, number=-1):
-        """Iterate over each email address in the authenticated
-        user's account.
+        """Iterate over each email address in the authenticated user's account.
 
         :param int number: (optional), number of email addresses to return.
             Default: -1, returns all of them
diff --git a/tests/test_users.py b/tests/test_users.py
@@ -23,20 +23,6 @@ def test_str(self):
         assert self.plan.is_free()
 
 
-class TestUserEmail(BaseCase):
-    def __init__(self, methodName='runTest'):
-        super(TestUserEmail, self).__init__(methodName)
-        self.useremail = github3.users.UserEmail({
-            'email': 'test@email.com',
-            'verified': True,
-            'primary': True,
-        })
-
-    def test_str(self):
-        assert str(self.useremail) == self.useremail.email
-        assert repr(self.useremail) == '<UserEmail [test@email.com]>'
-
-
 class TestUser(BaseCase):
     def __init__(self, methodName='runTest'):
         super(TestUser, self).__init__(methodName)
diff --git a/tests/unit/test_users.py b/tests/unit/test_users.py
@@ -86,6 +86,17 @@ class TestUserIterators(UnitIteratorHelper):
     described_class = github3.users.User
     example_data = example_data.copy()
 
+    def test_email_addresses(self):
+        """Verify the request to retrive a user's email addresses."""
+        i = self.instance.email_addresses()
+        self.get_next(i)
+
+        self.session.get.assert_called_once_with(
+            url_for('user/emails'),
+            params={'per_page': 100},
+            headers={}
+        )
+
     def test_events(self):
         """Test the request to retrieve a user's events."""
         i = self.instance.events()
