Found a very critical bug in github3/models.

sigmavirus24 · sigmavirus24 · commit 90d6600608e1 · 2012-09-24T17:20:31.000-04:00
In _put() I had not taken into account that there are instances where put is
used with data. The instances where it is not it is *required* to send '0' as
the Content-Length header. Other than that, requests should handle the content
length. It was a simple fix.
diff --git a/github3/issues.py b/github3/issues.py
@@ -320,10 +320,10 @@ def remove_label(self, name):
         """Removes label ``name`` from this issue.
 
         :param str name: (required), name of the label to remove
-        :returns: bool
+        :returns: list of labels remaining
         """
         url = self._build_url('labels', name, base_url=self._api)
-        return self._boolean(self._delete(url), 200, 404)
+        return self._json(self._delete(url), 200)
 
     @requires_auth
     def remove_all_labels(self):
@@ -343,7 +343,7 @@ def replace_labels(self, labels):
         :returns: bool
         """
         url = self._build_url('labels', base_url=self._api)
-        return self._boolean(self._put(url, dumps(labels)), 200, 404)
+        return self._boolean(self._put(url, data=dumps(labels)), 200, 404)
 
     @requires_auth
     def reopen(self):
diff --git a/github3/models.py b/github3/models.py
@@ -120,7 +120,8 @@ def _post(self, url, data=None, **kwargs):
     def _put(self, url, **kwargs):
         req = False
         if self._remaining > 0:
-            kwargs.update(headers={'Content-Length': '0'})
+            if 'data' not in kwargs:
+                kwargs.update(headers={'Content-Length': '0'})
             req = self._session.put(url, **kwargs)
         return req
 
diff --git a/tests/test_issues.py b/tests/test_issues.py
@@ -113,9 +113,9 @@ def test_with_auth(self):
         issue.edit(old_title, old_body)
         expect(issue.edit(None)).is_False()
         issue.add_labels('wontfix', 'Enhancement')
-        expect(issue.remove_label('wontfix')).is_True()
-        expect(issue.remove_label('wontfix')).is_False()
-        expect(issue.replace_labels('invalid', 'duplicate')).is_True()
+        expect(issue.remove_label('wontfix')).isinstance(list)
+        expect(issue.remove_label('wontfix')).isinstance(list)
+        expect(issue.replace_labels(['invalid', 'duplicate'])).is_True()
         expect(issue.remove_all_labels()).is_True()
 
 
