Add tests around the basic_auth/token_auth changes

Barry Morrison and Ian Cordasco · sigmavirus24 · commit 8a630a1cc0b5 · 2014-02-17T21:36:40.000-06:00
Ensure the behavior is observed in the tests so this does not regress.
diff --git a/tests/unit/test_github_session.py b/tests/unit/test_github_session.py
@@ -72,6 +72,18 @@ def test_basic_login(self):
         s.basic_auth('username', 'password')
         assert s.auth == ('username', 'password')
 
+    def test_basic_login_disables_token_auth(self):
+        """Test that basic auth will remove the Authorization header.
+
+        Token and basic authentication will conflict so remove the token
+        authentication.
+        """
+        s = self.build_session()
+        s.token_auth('token goes here')
+        assert 'Authorization' in s.headers
+        s.basic_auth('username', 'password')
+        assert 'Authorization' not in s.headers
+
     @patch.object(requests.Session, 'request')
     def test_handle_two_factor_auth(self, request_mock):
         """Test the method that handles getting the 2fa code"""
@@ -121,6 +133,16 @@ def test_token_auth(self):
         s.token_auth('token goes here')
         assert s.headers['Authorization'] == 'token token goes here'
 
+    def test_token_auth_disables_basic_auth(self):
+        """Test that using token auth removes the value of the auth attribute.
+
+        If `GitHubSession.auth` is set then it conflicts with the token value.
+        """
+        s = self.build_session()
+        s.auth = ('foo', 'bar')
+        s.token_auth('token goes here')
+        assert s.auth is None
+
     def test_token_auth_does_not_use_falsey_values(self):
         """Test that token auth will not authenticate with falsey values"""
         bad_tokens = [None, '']
