Add support for specifying a release asset label at upload.

sunu · sunu · commit 65a4134deaff · 2015-11-18T22:48:24.000+05:30
diff --git a/github3/repos/release.py b/github3/repos/release.py
@@ -160,7 +160,7 @@ def edit(self, tag_name=None, target_commitish=None, name=None, body=None,
         return successful
 
     @requires_auth
-    def upload_asset(self, content_type, name, asset):
+    def upload_asset(self, content_type, name, asset, label=None):
         """Upload an asset to this release.
 
         All parameters are required.
@@ -169,11 +169,14 @@ def upload_asset(self, content_type, name, asset):
             a list of common media types
         :param str name: The name of the file
         :param asset: The file or bytes object to upload.
+        :param label: (optional), An alternate short description of the asset.
         :returns: :class:`Asset <Asset>`
         """
         headers = Release.CUSTOM_HEADERS.copy()
         headers.update({'Content-Type': content_type})
-        url = self.upload_urlt.expand({'name': name})
+        params = {'name': name, 'label': label}
+        self._remove_none(params)
+        url = self.upload_urlt.expand(params)
         r = self._post(url, data=asset, json=False, headers=headers)
         if r.status_code in (201, 202):
             return Asset(r.json(), self)
diff --git a/tests/integration/test_repos_release.py b/tests/integration/test_repos_release.py
@@ -77,11 +77,28 @@ def test_upload_asset(self):
                 )
             with open(__file__) as fd:
                 asset = release.upload_asset(
-                    'text/plain', 'test_repos_release.py', fd.read()
-                    )
+                    'text/plain', 'test_repos_release.py', fd.read(),
+                )
             assert isinstance(asset, github3.repos.release.Asset)
             release.delete()
 
+    def test_upload_asset_with_a_label(self):
+        """Test the ability to upload an asset to a release with a label."""
+        self.token_login()
+        cassette_name = self.cassette_name('upload_asset_with_a_label')
+        with self.recorder.use_cassette(cassette_name):
+            repository = self.gh.repository('github3py', 'github3.py')
+            release = repository.create_release(
+                '0.8.0.pre', 'develop', '0.8.0 fake release with upload',
+                'To be deleted'
+                )
+            with open(__file__) as fd:
+                asset = release.upload_asset(
+                    'text/plain', 'test_repos_release.py', fd.read(),
+                    'test-label',
+                )
+            assert isinstance(asset, github3.repos.release.Asset)
+            release.delete()
 
 class TestAsset(IntegrationHelper):
     def test_delete(self):
