Skip to content

Commit 61ae20f

Browse files
committed
Fix-up github3.pulls API reference
Clean-up our documentation build as well.
1 parent d9d1c25 commit 61ae20f

6 files changed

Lines changed: 36 additions & 28 deletions

File tree

docs/source/api-reference/models.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ future developers of this library.
1111
These classes are only to be used internally in development of this
1212
library.
1313

14-
.. autoclass:: GitHubCore
14+
.. autoclass:: github3.models.GitHubCore
1515
:inherited-members:

docs/source/api-reference/notifications.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ all of the classes used to represent notification objects in github3.py.
99
Notification Objects
1010
--------------------
1111

12-
.. autoclass:: Thread
12+
.. autoclass:: github3.notifications.Thread
1313
:inherited-members:
1414

15-
.. autoclass:: ThreadSubscription
15+
.. autoclass:: github3.notifications.ThreadSubscription
1616
:inherited-members:
1717

18-
.. autoclass:: RepositorySubscription
18+
.. autoclass:: github3.notifications.RepositorySubscription
1919
:inherited-members:
Lines changed: 23 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,38 @@
1-
.. module:: github3
2-
.. module:: github3.pulls
1+
============================================
2+
Pull Requests and their Associated Objects
3+
============================================
34

4-
Pull Request
5-
============
6-
7-
This section of the documentation covers:
8-
9-
- :class:`PullRequest <PullRequest>`
10-
- :class:`ReviewComment <ReviewComment>`
11-
- :class:`PullDestination <PullDestination>`
12-
- :class:`PullFile <PullFile>`
5+
This section of the documentation covers the representations of various
6+
objects related to the `Pull Requests API`_.
137

148
Pull Request Objects
159
--------------------
1610

17-
.. autoclass:: PullRequest
11+
.. autoclass:: github3.pulls.ShortPullRequest
1812
:inherited-members:
1913

20-
------
14+
.. autoclass:: github3.pulls.PullRequest
15+
:inherited-members:
2116

22-
.. autoclass:: ReviewComment
17+
.. autoclass:: github3.pulls.PullDestination
2318
:inherited-members:
2419

25-
------
20+
.. autoclass:: github3.pulls.Head
21+
22+
.. autoclass:: github3.pulls.Base
2623

27-
.. autoclass:: PullDestination
24+
.. autoclass:: github3.pulls.PullFile
2825
:inherited-members:
2926

30-
------
3127

32-
.. autoclass:: PullFile
28+
Review Objects
29+
--------------
30+
31+
.. autoclass:: github3.pulls.ReviewComment
3332
:inherited-members:
33+
34+
35+
.. ---
36+
.. links
37+
.. _Pull Requests API:
38+
https://developer.github.com/v3/pulls/

docs/source/release-notes/index.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ here with the newest releases first.
99
==================
1010

1111
.. toctree::
12+
1.0.2
1213
1.0.1
1314
1.0.0
1415

github3/issues/event.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ class RepositoryIssueEvent(IssueEvent):
8282
8383
This object will be instantiated from calling
8484
:meth:`~github3.repos.repo.Repository.issue_events` or
85-
:meth:`~github3.repos.repo.ShortRepository.issue_events`which call
85+
:meth:`~github3.repos.repo.ShortRepository.issue_events` which call
8686
https://developer.github.com/v3/issues/events/#list-events-for-a-repository
8787
8888
See also: http://developer.github.com/v3/issues/events

github3/issues/issue.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,13 @@ def edit(self, title=None, body=None, assignee=None, state=None,
197197
:param str state:
198198
accepted values: ('open', 'closed')
199199
:param int milestone:
200-
the NUMBER (not title) of the milestone to assign this to [1]_, or
201-
0 to remove the milestone
200+
the number (not title) of the milestone to assign this to,
201+
or 0 to remove the milestone
202+
203+
.. note::
204+
205+
This is not the milestone's globally unique identifier, it's
206+
value in :attr:`~github3.issues.milestone.Milestone.number`.
202207
:param list labels:
203208
list of labels to apply this to
204209
:param assignees:
@@ -209,9 +214,6 @@ def edit(self, title=None, body=None, assignee=None, state=None,
209214
True if successful, False otherwise
210215
:rtype:
211216
bool
212-
213-
.. [1] Milestone numbering starts at 1, i.e. the first milestone you
214-
create is 1, the second is 2, etc.
215217
"""
216218
json = None
217219
data = {'title': title, 'body': body, 'assignee': assignee,

0 commit comments

Comments
 (0)