Skip to content

Commit 2925386

Browse files
committed
Fix a consistency issue.
1 parent a81dc50 commit 2925386

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

HISTORY.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ History/Changelog
1414

1515
- is_active() and active return the same value
1616

17+
- In github3.pulls.PullRequest
18+
19+
- is_mergeable() and mergeable are now the same
20+
1721
- Some objects now have ``__str__`` methods. You can now do things like:
1822

1923
::

github3/pulls.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ def __init__(self, pull, session=None):
128128
# If the pull request has been merged
129129
if self.merged_at:
130130
self.merged_at = self._strptime(self.merged_at)
131-
self._mergeable = pull.get('mergeable')
131+
self.mergeable = pull.get('mergeable', False)
132132
#: :class:`User <github3.users.User>` who merged this pull
133133
self.merged_by = pull.get('merged_by')
134134
if self.merged_by:
@@ -168,7 +168,7 @@ def is_mergeable(self):
168168
169169
:returns: bool
170170
"""
171-
return False if self._mergeable is None else self._mergeable
171+
return self.mergeable
172172

173173
def is_merged(self):
174174
"""Checks to see if the pull request was merged.
@@ -248,6 +248,7 @@ def merge(self, commit_message=''):
248248
data = {'commit_message': commit_message}
249249
url = self._build_url('merge', base_url=self._api)
250250
resp = self._put(url, data)
251+
self.merge_commit_sha = resp['merge_commit_sha']
251252
return resp.json['merged']
252253

253254
@requires_auth

0 commit comments

Comments
 (0)