Skip to content

Commit c63bdeb

Browse files
committed
Changes to OnTitleChange, the default behavior is exposed via api,
if you overwrite that function handler you can still call these 2 functions: cefpython.EnforceWindowTitle(browser, title) cefpython.EnforceWindowIcon(browser)
1 parent 582efc8 commit c63bdeb

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

cefexample/README.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@ icon.ico
4343

4444
CHANGELOG.
4545

46+
Version 0.37 released on 2012-08-30.
47+
* [DisplayHandler] implemented.
48+
* Popups have window titles set, also icons are inherited from parent window (Issue 3).
49+
4650
Version 0.36 released on 2012-08-29.
4751
* Support for Http Authentication (Issue 8).
4852
* [RequestHandler] is now partially implemented.

cefexample/cefadvanced.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ def CefAdvanced():
3030
cefwindow.__debug = True # Whether to print debug output to console.
3131
cefpython.__debug = True
3232

33+
print("cefpython.EnforceWindowTitle: %s" % cefpython.EnforceWindowTitle)
34+
3335
appSettings = dict() # See: http://code.google.com/p/cefpython/wiki/AppSettings
3436
#appSettings["user_agent"] = "MYAGENT 0.10"
3537
appSettings["multi_threaded_message_loop"] = False

displayhandler.pyx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,17 +97,19 @@ cdef public void DisplayHandler_OnTitleChange(CefRefPtr[CefBrowser] cefBrowser,
9797
try:
9898
pyBrowser = GetPyBrowserByCefBrowser(cefBrowser)
9999
pyTitle = CefStringToPyString(cefTitle)
100-
EnforceWindowTitle(pyBrowser, pyTitle)
101-
EnforceWindowIcon(pyBrowser)
102100
handler = pyBrowser.GetClientHandler("OnTitleChange")
103101
if handler:
104102
handler(pyBrowser, pyTitle)
105-
return
103+
return
104+
else:
105+
EnforceWindowTitle(pyBrowser, pyTitle)
106+
EnforceWindowIcon(pyBrowser)
107+
return
106108
except:
107109
(exc_type, exc_value, exc_trace) = sys.exc_info()
108110
sys.excepthook(exc_type, exc_value, exc_trace)
109111

110-
cdef void EnforceWindowTitle(pyBrowser, pyTitle):
112+
def EnforceWindowTitle(pyBrowser, pyTitle):
111113

112114
# Each browser window should have a title (Issue 3).
113115
# When popup is created, the window that sits in taskbar has no title.
@@ -132,7 +134,7 @@ cdef void EnforceWindowTitle(pyBrowser, pyTitle):
132134
if not currentTitle:
133135
win32gui.SetWindowText(windowID, pyTitle)
134136

135-
cdef void EnforceWindowIcon(pyBrowser):
137+
def EnforceWindowIcon(pyBrowser):
136138

137139
# Each popup window should inherit icon from the main window.
138140

0 commit comments

Comments
 (0)