Fixes to OnClose in wxpython.py. It is not required to call CloseBrowser

cztomczak · cztomczak · commit 9eca63451a00 · 2015-01-13T14:20:12.000+01:00
nor StopLoad.
diff --git a/cefpython/cef3/windows/binaries/wxpython.py b/cefpython/cef3/windows/binaries/wxpython.py
@@ -211,19 +211,17 @@ def OnSize(self, event):
         cefpython.WindowUtils.OnSize(self.GetHandleForBrowser(), 0, 0, 0)
 
     def OnClose(self, event):
-        if self.browser:
-            # Calling CloseBrowser will cause that OnClose event occurs again,
-            # so self.browser must be checked if non-empty.
-            self.browser.StopLoad()
-            self.browser.CloseBrowser()
-            # Remove all CEF browser references so that browser is closed
-            # cleanly. Otherwise there may be issues for example with cookies
-            # not being flushed to disk when closing app immediately
-            # (Issue 158).
-            del self.javascriptExternal.mainBrowser
-            del self.clientHandler.mainBrowser
-            del self.browser
-            self.Destroy()
+        # Remove all CEF browser references so that browser is closed
+        # cleanly. Otherwise there may be issues for example with cookies
+        # not being flushed to disk when closing app immediately
+        # (Issue 158).
+        del self.javascriptExternal.mainBrowser
+        del self.clientHandler.mainBrowser
+        del self.browser
+
+        # Destroy wx frame, this will complete the destruction of CEF browser
+        self.Destroy()
+
         # In wx.chromectrl calling browser.CloseBrowser and/or self.Destroy
         # may cause crashes when embedding multiple browsers in tab
         # (Issue 107). In such case instead of calling CloseBrowser/Destroy
