Fix PyCharm warnings in qt.py and update tested configurat. in gtk3.py

cztomczak · cztomczak · commit 804a0a121787 · 2017-04-22T08:13:16.000+02:00
diff --git a/README.md b/README.md
@@ -38,9 +38,10 @@ or other kind of internet bots.
 
 ## Install
 
-You can install with pip. On Linux pip 8.1+ is required. You can
+You can install [pypi/cefpython3](https://pypi.python.org/pypi/cefpython3)
+package using pip tool. On Linux pip 8.1+ is required. You can
 also download packages for offline installation available on the
-[GitHub Releases](../../releases) pages.
+[GitHub Releases](../../releases) pages. Command to install with pip:
 
 ```
 pip install cefpython3==57.0
diff --git a/examples/gtk3.py b/examples/gtk3.py
@@ -1,16 +1,13 @@
 # Example of embedding CEF Python browser using PyGObject/PyGI (GTK 3).
 #
-# Mac note: This example crashes on Mac with error message:
-#           > _createMenuRef called with existing principal MenuRef..
-#           Reported as Issue #310.
-#
-# Linux note: This example is currently broken in v54+ on Linux (Issue #261).
-#             It works fine with cefpython v53.
-#
 # Tested configurations:
-# - GTK 3.18 on Windows
-# - GTK 3.10 on Linux
-# - CEF Python v53.1+
+# - GTK 3.18 on Windows (cefpython v53.1+)
+# - GTK 3.10 on Linux (works with cefpython v53.1 and v57.0+)
+#
+# Mac crash: This example crashes on Mac with error message:
+#            > _createMenuRef called with existing principal MenuRef..
+#            Reported as Issue #310.
+
 
 from cefpython3 import cefpython as cef
 import ctypes
diff --git a/examples/qt.py b/examples/qt.py
@@ -24,22 +24,29 @@
 PYQT5 = False
 PYSIDE = False
 
-# PyQt imports
 if "pyqt4" in sys.argv:
     PYQT4 = True
+    # noinspection PyUnresolvedReferences
     from PyQt4.QtGui import *
+    # noinspection PyUnresolvedReferences
     from PyQt4.QtCore import *
 elif "pyqt5" in sys.argv:
     PYQT5 = True
+    # noinspection PyUnresolvedReferences
     from PyQt5.QtGui import *
+    # noinspection PyUnresolvedReferences
     from PyQt5.QtCore import *
+    # noinspection PyUnresolvedReferences
     from PyQt5.QtWidgets import *
-# PySide imports
 elif "pyside" in sys.argv:
     PYSIDE = True
+    # noinspection PyUnresolvedReferences
     import PySide
+    # noinspection PyUnresolvedReferences
     from PySide import QtCore
+    # noinspection PyUnresolvedReferences
     from PySide.QtGui import *
+    # noinspection PyUnresolvedReferences
     from PySide.QtCore import *
 else:
     print("USAGE:")
@@ -63,6 +70,7 @@
 # OS differences
 CefWidgetParent = QWidget
 if LINUX and (PYQT4 or PYSIDE):
+    # noinspection PyUnresolvedReferences
     CefWidgetParent = QX11EmbedContainer
 
 
@@ -98,6 +106,7 @@ def check_versions():
 
 class MainWindow(QMainWindow):
     def __init__(self):
+        # noinspection PyArgumentList
         super(MainWindow, self).__init__(None)
         self.cef_widget = None
         self.navigation_bar = None
@@ -115,12 +124,15 @@ def setupLayout(self):
         self.cef_widget = CefWidget(self)
         self.navigation_bar = NavigationBar(self.cef_widget)
         layout = QGridLayout()
+        # noinspection PyArgumentList
         layout.addWidget(self.navigation_bar, 0, 0)
+        # noinspection PyArgumentList
         layout.addWidget(self.cef_widget, 1, 0)
         layout.setContentsMargins(0, 0, 0, 0)
         layout.setSpacing(0)
         layout.setRowStretch(0, 0)
         layout.setRowStretch(1, 1)
+        # noinspection PyArgumentList
         frame = QFrame()
         frame.setLayout(layout)
         self.setCentralWidget(frame)
@@ -140,8 +152,10 @@ def setupLayout(self):
             # a hidden window, embed CEF browser in it and then
             # create a container for that hidden window and replace
             # cef widget in the layout with the container.
+            # noinspection PyUnresolvedReferences, PyArgumentList
             self.container = QWidget.createWindowContainer(
                     self.cef_widget.hidden_window, parent=self)
+            # noinspection PyArgumentList
             layout.addWidget(self.container, 1, 0)
 
     def closeEvent(self, event):
@@ -158,6 +172,7 @@ def clear_browser_references(self):
 
 class CefWidget(CefWidgetParent):
     def __init__(self, parent=None):
+        # noinspection PyArgumentList
         super(CefWidget, self).__init__(parent)
         self.parent = parent
         self.browser = None
@@ -180,6 +195,7 @@ def focusOutEvent(self, event):
 
     def embedBrowser(self):
         if PYQT5 and LINUX:
+            # noinspection PyUnresolvedReferences
             self.hidden_window = QWindow()
         window_info = cef.WindowInfo()
         rect = [0, 0, self.width(), self.height()]
@@ -246,6 +262,7 @@ def __init__(self, args):
 
     def createTimer(self):
         timer = QTimer()
+        # noinspection PyUnresolvedReferences
         timer.timeout.connect(self.onTimer)
         timer.start(10)
         return timer
@@ -301,6 +318,7 @@ def OnGotFocus(self, browser, **_):
 
 class NavigationBar(QFrame):
     def __init__(self, cef_widget):
+        # noinspection PyArgumentList
         super(NavigationBar, self).__init__()
         self.cef_widget = cef_widget
 
@@ -311,22 +329,30 @@ def __init__(self, cef_widget):
 
         # Back button
         self.back = self.createButton("back")
+        # noinspection PyUnresolvedReferences
         self.back.clicked.connect(self.onBack)
+        # noinspection PyArgumentList
         layout.addWidget(self.back, 0, 0)
 
         # Forward button
         self.forward = self.createButton("forward")
+        # noinspection PyUnresolvedReferences
         self.forward.clicked.connect(self.onForward)
+        # noinspection PyArgumentList
         layout.addWidget(self.forward, 0, 1)
 
         # Reload button
         self.reload = self.createButton("reload")
+        # noinspection PyUnresolvedReferences
         self.reload.clicked.connect(self.onReload)
+        # noinspection PyArgumentList
         layout.addWidget(self.reload, 0, 2)
 
         # Url input
         self.url = QLineEdit("")
+        # noinspection PyUnresolvedReferences
         self.url.returnPressed.connect(self.onGoUrl)
+        # noinspection PyArgumentList
         layout.addWidget(self.url, 0, 3)
 
         # Layout
