Update pysdl2.py example - support for Windows, performance fixes

cztomczak · cztomczak · commit 5dbd9d6553cc · 2018-02-20T19:59:54.000+01:00
diff --git a/examples/README-examples.md b/examples/README-examples.md
@@ -45,7 +45,8 @@ workarounds.
   library (GTK 3). Currently broken on Mac ([#310](../../../issues/310)).
 - [pysdl2.py](pysdl2.py): off-screen rendering example for
   [PySDL2](https://github.com/marcusva/py-sdl2) library. Currently tested
-  only on Linux ([#324](../../../issues/324)).
+  and works fine on Linux and Windows. For Mac support and performance
+  tweaking see Issue [#324](../../../issues/324).
 - [pywin32.py](pywin32.py): example for [pywin32](https://github.com/mhammond/pywin32)
   library
 - [qt.py](qt.py): example for [PyQt4](https://wiki.python.org/moin/PyQt4),
diff --git a/examples/pysdl2.py b/examples/pysdl2.py
@@ -7,17 +7,21 @@
 Requires PySDL2 and SDL2 libraries.
  
 Tested configurations:
+- Windows 7: SDL 2.0.7 and PySDL2 0.9.6
 - Fedora 25: SDL2 2.0.5 with PySDL2 0.9.3
 - Ubuntu 14.04: SDL2 with PySDL2 0.9.6
 
 Install instructions:
 1. Install SDL libraries for your OS, e.g:
+   - Windows: Download SDL2.dll from http://www.libsdl.org/download-2.0.php
+              and put SDL2.dll in C:\Python27\ (where you've installed Python)
    - Fedora: sudo dnf install SDL2 SDL2_ttf SDL2_image SDL2_gfx SDL2_mixer
    - Ubuntu: sudo apt-get install libsdl2-dev
 2. Install PySDL2 using pip package manager:
    pip install PySDL2
  
 Missing functionality:
+- Performance is still not perfect, see Issue #379 for further details
 - Keyboard modifiers that are not yet handled in this example:
   ctrl, marking text inputs with the shift key.
 - Mouse dragging
@@ -69,10 +73,23 @@ def main():
     browserHeight = height - headerHeight
     browserWidth = width
     # Mouse wheel fudge to enhance scrolling
-    scrollEnhance = 20
+    scrollEnhance = 40
     # Initialise CEF for offscreen rendering
     sys.excepthook = cef.ExceptHook
-    cef.Initialize(settings={"windowless_rendering_enabled": True})
+    switches = {
+        # Tweaking OSR performance by setting the same Chromium flags
+        # as in upstream cefclient (Issue #240).
+        "disable-surfaces": "",
+        "disable-gpu": "",
+        "disable-gpu-compositing": "",
+        "enable-begin-frame-scheduling": "",
+    }
+    browser_settings = {
+        # Tweaking OSR performance (Issue #240)
+        "windowless_frame_rate": 100
+    }
+    cef.Initialize(settings={"windowless_rendering_enabled": True},
+                   switches=switches)
     window_info = cef.WindowInfo()
     window_info.SetAsOffscreen(0)
     # Initialise SDL2 for video (add other init constants if you
@@ -96,7 +113,9 @@ def main():
     # Set-up the RenderHandler, passing in the SDL2 renderer
     renderHandler = RenderHandler(renderer, width, height - headerHeight)
     # Create the browser instance
-    browser = cef.CreateBrowserSync(window_info, url="https://www.google.com/")
+    browser = cef.CreateBrowserSync(window_info,
+                                    url="https://www.google.com/",
+                                    settings=browser_settings)
     browser.SetClientHandler(LoadHandler())
     browser.SetClientHandler(renderHandler)
     # Must call WasResized at least once to let know CEF that
