Skip to content

Commit 37fecd8

Browse files
cztomczakcztomczak
committed
Remove BrowserSettings.javascript_open_windows_disallowed option (cztomczak#403)
1 parent f699c59 commit 37fecd8

File tree

7 files changed

+11
-18
lines changed

7 files changed

+11
-18
lines changed

‎README.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,6 @@ Additional information for v31.2 release:
436436
* [file_access_from_file_urls_allowed](api/BrowserSettings.md#file_access_from_file_urls_allowed)
437437
* [image_load_disabled](api/BrowserSettings.md#image_load_disabled)
438438
* [javascript_disabled](api/BrowserSettings.md#javascript_disabled)
439-
* [javascript_open_windows_disallowed](api/BrowserSettings.md#javascript_open_windows_disallowed)
440439
* [javascript_close_windows_disallowed](api/BrowserSettings.md#javascript_close_windows_disallowed)
441440
* [javascript_access_clipboard_disallowed](api/BrowserSettings.md#javascript_access_clipboard_disallowed)
442441
* [local_storage_disabled](api/BrowserSettings.md#local_storage_disabled)

‎api/API-index.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@
122122
* [file_access_from_file_urls_allowed](BrowserSettings.md#file_access_from_file_urls_allowed)
123123
* [image_load_disabled](BrowserSettings.md#image_load_disabled)
124124
* [javascript_disabled](BrowserSettings.md#javascript_disabled)
125-
* [javascript_open_windows_disallowed](BrowserSettings.md#javascript_open_windows_disallowed)
126125
* [javascript_close_windows_disallowed](BrowserSettings.md#javascript_close_windows_disallowed)
127126
* [javascript_access_clipboard_disallowed](BrowserSettings.md#javascript_access_clipboard_disallowed)
128127
* [local_storage_disabled](BrowserSettings.md#local_storage_disabled)

‎api/BrowserSettings.md‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ Table of contents:
1717
* [file_access_from_file_urls_allowed](#file_access_from_file_urls_allowed)
1818
* [image_load_disabled](#image_load_disabled)
1919
* [javascript_disabled](#javascript_disabled)
20-
* [javascript_open_windows_disallowed](#javascript_open_windows_disallowed)
2120
* [javascript_close_windows_disallowed](#javascript_close_windows_disallowed)
2221
* [javascript_access_clipboard_disallowed](#javascript_access_clipboard_disallowed)
2322
* [local_storage_disabled](#local_storage_disabled)
@@ -117,11 +116,6 @@ Description from upstream CEF:
117116
(bool) Controls whether Javascript can be executed. Also configurable using the --disable-javascript switch.
118117

119118

120-
### javascript_open_windows_disallowed
121-
122-
(bool) Controls whether Javascript can be used for opening windows. Also configurable using the --disable-javascript-open-windows switch.
123-
124-
125119
### javascript_close_windows_disallowed
126120

127121
(bool) Controls whether JavaScript can be used to close windows that were not

‎docs/Migration-guide.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ Table of contents:
4141
* [v66+ LifespanHandler.OnBeforePopup is now called on UI thread](#v66-lifespanhandleronbeforepopup-is-now-called-on-ui-thread)
4242
* [v66+ RequestHandler.OnBeforeBrowse has a new param 'user_gesture'](#v66-requesthandleronbeforebrowse-has-a-new-param-user_gesture)
4343
* [v66+ Window transparency changes](#v66-window-transparency-changes)
44+
* [v66+ BrowserSettings.javascript_open_windows_disallowed option was removed](#v66-browsersettingsjavascript_open_windows_disallowed-option-was-removed)
4445

4546

4647

@@ -344,3 +345,9 @@ in exception**.
344345
transparent windows also in **windowed mode**. This seems to be working
345346
only on Linux (got it working on Fedora with just a change in window setting).
346347

348+
349+
## v66+ BrowserSettings.javascript_open_windows_disallowed option was removed
350+
351+
The BrowserSettings.`javascript_open_windows_disallowed` option was removed
352+
(setting it will do nothing).
353+

‎src/cef_v59..v66_changes.txt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ BREAKAGE (needs updating Migration Guide doc)
4343
- + Update Migration Guide doc
4444

4545
internal/cef_types.h
46-
- cef_settings_t:
47-
- javascript_open_windows option removed (keep a dummy for BC)
48-
- update Migration Guide
46+
- + cef_settings_t:
47+
- + javascript_open_windows option removed (keep a dummy for BC)
48+
- + update Migration Guide
4949
- cef_thread_id_t:
5050
- TID_DB removed (update Migration Guide)
5151
- TID_PROCESS_LAUNCHER removed (update Migration Guide)

‎src/extern/cef/cef_types.pxd‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ cdef extern from "include/internal/cef_types.h":
7878
cef_string_t default_encoding
7979
cef_state_t remote_fonts
8080
cef_state_t javascript
81-
cef_state_t javascript_open_windows
8281
cef_state_t javascript_close_windows
8382
cef_state_t javascript_access_clipboard
8483
cef_state_t javascript_dom_paste

‎src/settings.pyx‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -191,12 +191,7 @@ cdef void SetBrowserSettings(
191191
else:
192192
cefBrowserSettings.javascript = cef_types.STATE_ENABLED
193193
elif key == "javascript_open_windows_disallowed":
194-
if browserSettings[key]:
195-
cefBrowserSettings.javascript_open_windows = (
196-
cef_types.STATE_DISABLED)
197-
else:
198-
cefBrowserSettings.javascript_open_windows = (
199-
cef_types.STATE_ENABLED)
194+
Debug("DEPRECATED: 'javascript_open_windows_disallowed' setting")
200195
elif key == "javascript_close_windows_disallowed":
201196
if browserSettings[key]:
202197
cefBrowserSettings.javascript_close_windows = (

0 commit comments

Comments
 (0)