You can now get javascript stack trace, see: [cefpython].GetJavascriptStackTrace() and [cefpython].GetJavascriptStackTraceFormatted().

cztomczak · cztomczak · commit 36911208e798 · 2012-09-23T16:02:13.000+01:00
diff --git a/cefexample/_changelog.txt b/cefexample/_changelog.txt
@@ -1,6 +1,8 @@
 Version 0.42 not yet released.
  * Rebind/reload example added to cefadvanced.py.
  * en-US locale was outdated, came from revision `607`, locales/ directory contains all locales now, the default one is "en-US", others are optional and do not need to be distributed.
+ * OnConsoleMessage example added to cefadvanced.py
+ * You can now get javascript stack trace, see: [cefpython].GetJavascriptStackTrace() and [cefpython].GetJavascriptStackTraceFormatted().
 
 Version 0.41 released on 2012-09-14.
  * New options in [ApplicationSettings]: auto_detect_proxy_settings_enabled, pack_loading_disabled.
diff --git a/cefexample/cefadvanced.py b/cefexample/cefadvanced.py
@@ -140,7 +140,8 @@ def HandleJavascriptError(errorMessage, url, lineNumber):
 		url = re.sub(r"[/\\]+", re.escape(os.sep), url)
 		url = re.sub(r"%s" % re.escape(cefpython.GetRealPath()), "", url, flags=re.IGNORECASE)
 		url = re.sub(r"^%s" % re.escape(os.sep), "", url)
-	raise Exception("%s\n  in %s on line %s" % (errorMessage, url, lineNumber))
+	stackTrace = cefpython.GetJavascriptStackTraceFormatted()
+	raise Exception("%s\n in %s on line %s\n\n%s" % (errorMessage, url, lineNumber, stackTrace))
 
 class Python:
 
@@ -291,6 +292,9 @@ def OnConsoleMessage(self, browser, message, source, line):
 			appdir = appdir[0].upper() + appdir[1:]
 		source = source.replace("file:///", "")
 		source = source.replace(appdir, "")
+		#if (message.lower().find("error") != -1): # DOESN'T WORK, stack trace is empty in this context.
+			#stackTrace = cefpython.GetJavascriptStackTraceFormatted()
+			#raise Exception("%s\n in %s on line %s\n\n%s" % (message, source, line, stackTrace))
 		print("Console message: %s (%s:%s)\n" % (message, source, line));
 		return False
 
diff --git a/cefpython.pyx b/cefpython.pyx
@@ -258,3 +258,34 @@ def IsKeyModifier(key, modifiers):
 		return ((KEY_SHIFT  | KEY_CTRL | KEY_ALT) & modifiers) == 0
 		# Same as: return (KEY_CTRL & modifiers) != KEY_CTRL and (KEY_ALT & modifiers) != KEY_ALT and (KEY_SHIFT & modifiers) != KEY_SHIFT
 	return (key & modifiers) == key
+
+def GetJavascriptStackTrace(frameLimit=100):
+
+	cdef CefRefPtr[CefV8StackTrace] cefTrace = cef_v8_stack.GetCurrent(int(frameLimit))
+	cdef int frameCount = (<CefV8StackTrace*>(cefTrace.get())).GetFrameCount()
+	cdef CefRefPtr[CefV8StackFrame] cefFrame
+	cdef CefV8StackFrame* framePtr
+	pyTrace = []
+
+	for frameNo in range(0, frameCount):
+		cefFrame = (<CefV8StackTrace*>(cefTrace.get())).GetFrame(frameNo)
+		framePtr = <CefV8StackFrame*>(cefFrame.get())
+		pyFrame = {}		
+		pyFrame["script"] = CefStringToPyString(framePtr.GetScriptName())
+		pyFrame["scriptOrSourceURL"] = CefStringToPyString(framePtr.GetScriptNameOrSourceURL())
+		pyFrame["function"] = CefStringToPyString(framePtr.GetFunctionName())
+		pyFrame["line"] = framePtr.GetLineNumber()
+		pyFrame["column"] = framePtr.GetColumn()
+		pyFrame["isEval"] = framePtr.IsEval()
+		pyFrame["isConstructor"] = framePtr.IsConstructor()
+		pyTrace.append(pyFrame)
+	
+	return pyTrace
+
+def GetJavascriptStackTraceFormatted(frameLimit=100):
+
+	trace = GetJavascriptStackTrace(frameLimit)
+	formatted = "Stack trace:\n"
+	for frameNo, frame in enumerate(trace):
+		formatted += "\t[%s] %s() in %s on line %s (col:%s)\n" % (frameNo, frame["function"], frame["scriptOrSourceURL"], frame["line"], frame["column"])
+	return formatted
diff --git a/imports.pyx b/imports.pyx
@@ -61,6 +61,7 @@ cimport cef_types # cannot cimport *, that would cause name conflicts with const
 cimport cef_types_win # same as cef_types.
 from cef_v8 cimport *
 cimport cef_v8_static
+cimport cef_v8_stack
 from v8functionhandler cimport *
 from cef_request cimport *
 from cef_response cimport *
diff --git a/pyinclude/cef_v8.pxd b/pyinclude/cef_v8.pxd
@@ -79,12 +79,18 @@ cdef extern from "include/cef_v8.h":
 		CefRefPtr[CefV8Exception] GetException()
 		cbool ClearException()
 
-	cdef cppclass CefV8StackTrace(CefBase):		
-		pass
+	cdef cppclass CefV8StackTrace(CefBase):
+		
+		int GetFrameCount()
+		CefRefPtr[CefV8StackFrame] GetFrame(int index)
 
 	cdef cppclass CefV8StackFrame(CefBase):
-		pass
-
-
-
+		
+		CefString GetScriptName()
+		CefString GetScriptNameOrSourceURL()
+		CefString GetFunctionName()
+		int GetLineNumber()
+		int GetColumn()
+		cbool IsEval()
+		cbool IsConstructor()
 
diff --git a/pyinclude/cef_v8_stack.pxd b/pyinclude/cef_v8_stack.pxd
@@ -0,0 +1,15 @@
+# Copyright (c) 2012 CefPython Authors. All rights reserved.
+# License: New BSD License.
+# Website: http://code.google.com/p/cefpython/
+
+from cef_ptr cimport CefRefPtr
+from cef_v8 cimport CefV8StackTrace
+
+# Importing static methods only in this file. This is in a separate file as we do not want 
+# these names to be imported into global namespace, you will be using them like this:
+# > cimport cef_v8_stack
+# > cef_v8_stack.GetCurrent()
+
+cdef extern from "include/cef_v8.h" namespace "CefV8StackTrace":
+
+	cdef CefRefPtr[CefV8StackTrace] GetCurrent(int frame_limit)
diff --git a/pyinclude/cef_v8_static.pxd b/pyinclude/cef_v8_static.pxd
@@ -11,12 +11,10 @@ from cef_v8 cimport CefV8Context
 from cef_base cimport CefBase
 from libcpp cimport bool as cbool
 
-# Importing static methods.
-# This is in a separate file as we do not want these names to be imported
-# into global namespace, you will be using them like this:
-#
-# cimport cef_v8_static
-# cef_v8_static.CreateArray()
+# Importing static methods only in this file. This is in a separate file as we do not want 
+# these names to be imported into global namespace, you will be using them like this:
+# > cimport cef_v8_static
+# > cef_v8_static.CreateArray()
 
 cdef extern from "include/cef_v8.h" namespace "CefV8Value":
 
