Display exception from subprocess

sebastinas · sebastinas · commit fa3ad3a2708b · 2015-04-29T23:03:16.000+02:00
Signed-off-by: Sebastian Ramacher &lt;sebastian+dev@ramacher.at&gt;
diff --git a/bpython/repl.py b/bpython/repl.py
@@ -1001,9 +1001,7 @@ def open_in_external_editor(self, filename):
         editor_args = shlex.split(prepare_for_exec(self.config.editor,
                                                    encoding))
         args = editor_args + [prepare_for_exec(filename, encoding)]
-        if subprocess.call(args) == 0:
-            return True
-        return False
+        return subprocess.call(args) == 0:
 
     def edit_config(self):
         if not (os.path.isfile(self.config.config_path)):
@@ -1028,11 +1026,12 @@ def edit_config(self):
             else:
                 return False
 
-        if self.open_in_external_editor(self.config.config_path):
-            self.interact.notify(_('bpython config file edited. Restart '
-                                   'bpython for changes to take effect.'))
-        else:
-            self.interact.notify(_('Error editing config file.'))
+        try:
+            if self.open_in_external_editor(self.config.config_path):
+                self.interact.notify(_('bpython config file edited. Restart '
+                                       'bpython for changes to take effect.'))
+            except OSError as e:
+                self.interact.notify(_('Error editing config file: %s') % e)
 
 
 def next_indentation(line, tab_length):
