update TODOs

thomasballinger · thomasballinger · commit 33ecf7241ac0 · 2013-12-21T19:15:51.000-05:00
--HG--
branch : scroll-frontend
diff --git a/bpython/curtsies.py b/bpython/curtsies.py
@@ -41,7 +41,7 @@ def main(args=None, locals_=None, banner=None):
                     assert options, "don't pass in exec_args without options"
                     try:
                         # THIS IS NORMAL PYTHON
-                        #TODO replace this so that stdout is properly harvested for display!
+                        #TODO replace this so that stdout is properly harvested for display and rewind works
                         bpargs.exec_code(repl.interp, exec_args)
                     except SystemExit, e:
                         exit_value = e.args
@@ -69,7 +69,8 @@ def main(args=None, locals_=None, banner=None):
                         array, cursor_pos = repl.paint()
                         scrolled = term.render_to_terminal(array, cursor_pos)
                         repl.scroll_offset += scrolled
-                        # Could calculate this in repl?
+                        # Could this be calculated in the repl, avoiding this
+                        # two-way communication?
 
 if __name__ == '__main__':
     sys.exit(main())
diff --git a/bpython/curtsiesfrontend/repl.py b/bpython/curtsiesfrontend/repl.py
@@ -39,8 +39,7 @@
 #TODO other autocomplete modes (also fix in other bpython implementations)
 #TODO figure out what config.flush_output is
 #TODO figure out what options.quiet is
-#TODO use events instead of length-one queues for interthread communication
-
+#TODO add buffering to stdout to speed up output.
 
 from bpython.keys import cli_key_dispatch as key_dispatch
 
@@ -58,7 +57,6 @@ def process_event(self, e):
         assert self.has_focus
         if e in rl_char_sequences:
             self.cursor_offset_in_line, self.current_line = rl_char_sequences[e](self.cursor_offset_in_line, self.current_line)
-            #TODO EOF on ctrl-d
         elif isinstance(e, events.SigIntEvent):
             self.coderunner.sigint_happened = True
             self.has_focus = False
@@ -285,7 +283,7 @@ def process_event(self, e):
             raise NotImplementedError()
         elif e in key_dispatch[self.config.show_source_key]: #TODO
             raise NotImplementedError()
-        elif e in key_dispatch[self.config.suspend_key]: #TODO
+        elif e in key_dispatch[self.config.suspend_key]:
             raise SystemExit()
         elif e in ("",) + key_dispatch[self.config.exit_key]:
             if self._current_line == '':
@@ -500,7 +498,7 @@ def run_code_and_maybe_finish(self, for_code=None):
 
     def keyboard_interrupt(self):
         #TODO factor out the common cleanup from running a line
-        #TODO make rewind work properly with ctrl-c somehow
+        #TODO make rewind work properly with ctrl-c'd infinite loops
         self.cursor_offset_in_line = -1
         self.unhighlight_paren()
         self.display_lines.extend(self.display_buffer_lines)
@@ -680,10 +678,6 @@ def paint(self, about_to_exit=False):
             assert cursor_column >= 0, (cursor_column, len(self.current_cursor_line), len(self._current_line), self.cursor_offset_in_line)
 
         if self.list_win_visible:
-            #infobox not properly expanding window! try reduce( docs about halfway down a 80x24 terminal
-            #TODO what's the desired behavior here? Currently uses only the space already on screen,
-            # scrolling down only if there would have been more space above the current line, but being forced to put below
-            #TODO above description is not accurate - sometimes screen scrolls for docstring message
             logging.debug('infobox display code running')
             visible_space_above = history.height
             visible_space_below = min_height - cursor_row - 1
@@ -803,10 +797,6 @@ def reprint_line(self, lineno, tokens):
             self.display_buffer[lineno] = bpythonparse(format(tokens, self.formatter))
     def reevaluate(self, insert_into_history=False):
         """bpython.Repl.undo calls this"""
-        #TODO This almost works, but stdin.readline() doesn't work yet
-        #TODO other implementations have a enter no-history method, could do
-        # that instead of clearing history and getting it rewritten
-
         old_logical_lines = self.history
         self.history = []
         self.display_lines = []
diff --git a/bpython/curtsiesfrontend/replpainter.py b/bpython/curtsiesfrontend/replpainter.py
@@ -41,7 +41,6 @@ def paint_current_line(rows, columns, current_display_line):
 
 def matches_lines(rows, columns, matches, current, config):
     highlight_color = func_for_letter(config.color_scheme['operator'].lower())
-    #TODO ...that's not really what operator is for
 
     if not matches:
         return []
@@ -118,7 +117,6 @@ def formatted_argspec(argspec, columns, config):
             s += punctuation_color(', ')
         s += token_color('*%s' % (_args,))
 
-    #TODO what in the world is this about? Just transcribing from bpython/cli for now
     if py3 and kwonly:
         if not _args:
             if args:
