parens unsafely added to attribute completions

thomasballinger · thomasballinger · commit 2ecdf340fbd0 · 2015-12-11T08:35:26.000-05:00
diff --git a/bpython/autocomplete.py b/bpython/autocomplete.py
@@ -253,8 +253,10 @@ def matches(self, cursor_offset, line, **kwargs):
         matches = set(''.join([r.word[:-i], m])
                       for m in self.attr_matches(methodtext, locals_))
 
-        # TODO add open paren for methods via _callable_prefix (or decide not
-        # to) unless the first character is a _ filter out all attributes
+        # TODO add open paren for methods via _callable_prefix
+        matches = set(_callable_postfix(eval(m, locals_), m)
+                      for m in matches)
+        # unless the first character is a _ filter out all attributes
         # starting with a _
         if r.word.split('.')[-1].startswith('__'):
             pass
diff --git a/bpython/test/test_autocomplete.py b/bpython/test/test_autocomplete.py
@@ -242,7 +242,7 @@ def setUpClass(cls):
 
     def test_att_matches_found_on_instance(self):
         self.assertSetEqual(self.com.matches(2, 'a.', locals_={'a': Foo()}),
-                            set(['a.method', 'a.a', 'a.b']))
+                            set(['a.method(', 'a.a', 'a.b']))
 
     @skip_old_style
     def test_att_matches_found_on_old_style_instance(self):
