Merge pull request bpython#702 from thomasballinger/fix-urwid

sebastinas · web-flow · commit 19912165e22e · 2017-11-06T23:54:29.000+01:00
fix encoding issues in urwid and curses
diff --git a/bpython/cli.py b/bpython/cli.py
@@ -330,7 +330,7 @@ def __init__(self, scr, interp, statusbar, config, idle=None):
         repl.Repl.__init__(self, interp, config)
         self.interp.writetb = self.writetb
         self.scr = scr
-        self.stdout_hist = ''
+        self.stdout_hist = ''  # native str (bytes in Py2, unicode in Py3)
         self.list_win = newwin(get_colpair(config, 'background'), 1, 1, 1, 1)
         self.cpos = 0
         self.do_exit = False
@@ -1066,13 +1066,19 @@ def prompt(self, more):
         """Show the appropriate Python prompt"""
         if not more:
             self.echo("\x01%s\x03%s" % (self.config.color_scheme['prompt'], self.ps1))
-            self.stdout_hist += self.ps1
+            if py3:
+                self.stdout_hist += self.ps1
+            else:
+                self.stdout_hist += self.ps1.encode(getpreferredencoding())
             self.s_hist.append('\x01%s\x03%s\x04' %
                                (self.config.color_scheme['prompt'], self.ps1))
         else:
             prompt_more_color = self.config.color_scheme['prompt_more']
             self.echo("\x01%s\x03%s" % (prompt_more_color, self.ps2))
-            self.stdout_hist += self.ps2
+            if py3:
+                self.stdout_hist += self.ps2
+            else:
+                self.stdout_hist += self.ps2.encode(getpreferredencoding())
             self.s_hist.append('\x01%s\x03%s\x04' % (prompt_more_color, self.ps2))
 
     def push(self, s, insert_into_history=True):
diff --git a/bpython/urwid.py b/bpython/urwid.py
@@ -596,7 +596,7 @@ def __init__(self, event_loop, palette, interpreter, config):
         self.tooltip = urwid.ListBox(urwid.SimpleListWalker([]))
         self.tooltip.grid = None
         self.overlay = Tooltip(self.listbox, self.tooltip)
-        self.stdout_hist = ''
+        self.stdout_hist = ''  # native str (bytes in Py2, unicode in Py3)
 
         self.frame = urwid.Frame(self.overlay)
 
@@ -976,17 +976,17 @@ def prompt(self, more):
         # input to be the same type, using ascii as encoding. If the
         # caption is bytes this breaks typing non-ascii into bpython.
         if not more:
+            caption = ('prompt', self.ps1)
             if py3:
-                caption = ('prompt', self.ps1)
+                self.stdout_hist += self.ps1
             else:
-                caption = ('prompt', self.ps1.decode(getpreferredencoding()))
-            self.stdout_hist += self.ps1
+                self.stdout_hist += self.ps1.encode(getpreferredencoding())
         else:
+            caption = ('prompt_more', self.ps2)
             if py3:
-                caption = ('prompt_more', self.ps2)
+                self.stdout_hist += self.ps2
             else:
-                caption = ('prompt_more', self.ps2.decode(getpreferredencoding()))
-            self.stdout_hist += self.ps2
+                self.stdout_hist += self.ps2.encode(getpreferredencoding())
         self.edit = BPythonEdit(self.config, caption=caption)
 
         urwid.connect_signal(self.edit, 'change', self.on_input_change)
